Skip to content

Update/quickstart #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 1, 2018
Merged

Conversation

damain
Copy link
Contributor

@damain damain commented Mar 1, 2018

Updating quickstart for to use first vue-cli-template

@nativescript-vue-bot
Copy link

nativescript-vue-bot commented Mar 1, 2018

Deploy preview for nativescript-vue ready!

Built with commit 2d8f4b2

https://deploy-preview-50--nativescript-vue.netlify.com

$ tns create my-app --template nativescript-vue-template
$ cd my-app
### Scaffold project
```sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep it shell for proper syntax highlighting

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

$ cd my-app
### Scaffold project
```sh
$ npm install -g vue-cli
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably start advising vue-cli 3.x (@vue/cli with @vue/cli-init)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not following you entirely, should I change the command or just suggest that this is the we would do it in vue-cli 3?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I think vue cli 3.x will be the default very soon, so we might as well make the users install it right off the bat.

If both @vue/cli and @vue/cli-init are installed globally, we can use the 2.x templates like normal (vue init nativescript-vue/vue-cli-template <ProjectName>).

So just change this line to

$ npm install -g @vue/cli @vue/cli-init

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

```shell
$ tns create my-app --template nativescript-vue-template
$ cd my-app
### Scaffold project
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need these headings

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

$ tns run android # for android
### Install dependencies
```sh
$ npm install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can go in the previous code block, maybe separated by a new line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed

### Build, watch for changes and run the application
Platform below would be `ios` or `android`
```sh
$ npm run watch:<platform>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be a good idea to mention the build command as well, and then link to the template for more details.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I purposely left out the build command because its instructions to install / get started what do you think?. But I think the link should be there I'll add it

@rigor789 rigor789 merged commit 444b026 into nativescript-vue:master Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants