Skip to content

[Maint] use concurrency to cancel in-progress build_docs #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

psobolewskiPhD
Copy link
Member

References and relevant issues

Closes #172

Description

Adds a concurrency group to the build_docs action, so that in progress workflows are canceled

@psobolewskiPhD psobolewskiPhD added this to the 0.5.0 milestone Nov 20, 2023
@github-actions github-actions bot added the task label Nov 20, 2023
@psobolewskiPhD psobolewskiPhD added maintenance CI, dependencies, and other maintenance and removed task labels Nov 20, 2023
@psobolewskiPhD
Copy link
Member Author

If this works properly, I'll make PR to napari/napari.

Copy link
Member

@melissawm melissawm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@psobolewskiPhD psobolewskiPhD merged commit 0b183c3 into napari:main Nov 22, 2023
@psobolewskiPhD psobolewskiPhD deleted the add_concurrency branch November 22, 2023 01:55
@psobolewskiPhD
Copy link
Member Author

Looks like it's working, I tested in another pR with merge main and then a dummy commit:
https://github.com/napari/docs/actions/runs/6951862158?pr=242

@psobolewskiPhD
Copy link
Member Author

Actually, I'm not sure this is needed for napari/napari because build_docs doesn't run on every PR to main anymore.

Czaki pushed a commit to napari/napari that referenced this pull request Jan 4, 2024
# Description
This PR updates the build_docs workflow to match the latest napari/docs
workflow
Specifically add concurrency (napari/docs PR:
napari/docs#277 ) and to fix graphical issues
related to the xvfb action ( napari/docs PR:
napari/docs#294 )
Czaki pushed a commit to napari/napari that referenced this pull request Jan 10, 2024
This PR updates the build_docs workflow to match the latest napari/docs
workflow
Specifically add concurrency (napari/docs PR:
napari/docs#277 ) and to fix graphical issues
related to the xvfb action ( napari/docs PR:
napari/docs#294 )
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance CI, dependencies, and other maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Maintenance] Add concurrency and cancel-in-progress to PR workflow
3 participants