Update PipeParse Hl7 version check to use string.CompareOrdinal instead of using System.Version the former is more forgiving if a version contains non numerical characters

Author: milkshakeuk

CHANGELOG.md

@@ -7,6 +7,10 @@ All notable changes to this project will be documented in this file.
 
 ## Previous Releases
 ###
+
+## [3.0.3] - 2021-08-09
+This change updates the `PipeParser` Version check when obtaining encoding characters from a message object in order to encode it to HL7; `string.CompareOrdinal` is now used instead of `System.Version` which is more forgiving when a version contains non numerical characters.
+
 ## [3.0.2] - 2021-08-09
 This change gives nhapi [strong-named assemblies](https://docs.microsoft.com/en-us/dotnet/standard/assembly/strong-named), there are no codes changes.
 ### Bug Fixes

build/nHapi.v3.nuspec

@@ -2,7 +2,7 @@
 <package xmlns="http://schemas.microsoft.com/packaging/2013/05/nuspec.xsd">
     <metadata>
         <id>nhapi</id>
-        <version>3.0.2</version>
+        <version>3.0.3</version>
         <authors>Chad Chenoweth,Duane Edwards,Jake Aitchison</authors>
         <license type="expression">MPL-2.0</license>
         <projectUrl>https://github.com/nHapiNET/nHapi</projectUrl>
@@ -13,7 +13,7 @@
 NHapi allows Microsoft .NET developers to easily use an HL7 2.x object model. This object model allows for parsing and encoding HL7 2.x data to/from Pipe Delimited or XML formats. A very handy program for use in the health care industry.
 
 This project is NOT affiliated with the HL7 organization. This software just conforms to the HL7 2.x specifications.</description>
-        <releaseNotes>https://github.com/nHapiNET/nHapi/releases/tag/v3.0.2</releaseNotes>
+        <releaseNotes>https://github.com/nHapiNET/nHapi/releases/tag/v3.0.3</releaseNotes>
         <tags>HL7 parsing healthcare HAPI xml</tags>
         <readme>docs\README.md</readme>
         <dependencies>

src/NHapi.Base/NHapi.Base.csproj

@@ -4,15 +4,15 @@
     <TargetFrameworks>net35;netstandard2.0</TargetFrameworks>
     <DocumentationFile>bin\$(Configuration)\$(TargetFramework)\$(AssemblyName).xml</DocumentationFile>
     <PackageId>nhapi.base</PackageId>
-    <PackageVersion>3.0.2</PackageVersion>
+    <PackageVersion>3.0.3</PackageVersion>
     <Authors>Chad Chenoweth;Duane Edwards;Jake Aitchison</Authors>
     <PackageLicenseExpression>MIT</PackageLicenseExpression>
     <PackageProjectUrl>https://github.com/nHapiNET/nHapi</PackageProjectUrl>
     <RepositoryUrl>https://github.com/nHapiNET/nHapi.git</RepositoryUrl>
     <RepositoryType>git</RepositoryType>
     <Description>The core components for parsing/encoding HL7 messages. Contains the base classes and interfaces for datatypes, segments, and messages.</Description>
     <PackageTags>HL7;parsing;healthcare;HAPI;xml</PackageTags>
-    <PackageReleaseNotes>https://github.com/nHapiNET/nHapi/releases/tag/v3.0.2</PackageReleaseNotes>
+    <PackageReleaseNotes>https://github.com/nHapiNET/nHapi/releases/tag/v3.0.3</PackageReleaseNotes>
     <PackageReadmeFile>docs\README.md</PackageReadmeFile>
     <AssemblyOriginatorKeyFile>..\..\NHapi.snk</AssemblyOriginatorKeyFile>
     <GenerateAssemblyInfo>false</GenerateAssemblyInfo>

src/NHapi.Base/Parser/PipeParser.cs

@@ -819,10 +819,9 @@ private EncodingCharacters GetValidEncodingCharacters(char fieldSep, ISegment ms
                 Terser.Set(msh, 2, 0, 1, 1, encCharString);
             }
 
-            var version27 = new Version("2.7");
-            var messageVersion = new Version(msh.Message.Version);
+            var version27 = "2.7";
 
-            if (version27 > messageVersion && encCharString.Length != 4)
+            if (string.CompareOrdinal(version27, msh.Message.Version) > 0 && encCharString.Length != 4)
             {
                 throw new HL7Exception(
                     $"Encoding characters (MSH-2) value '{encCharString}' invalid -- must be 4 characters", ErrorCode.DATA_TYPE_ERROR);

src/SharedAssemblyInfo.cs

@@ -23,5 +23,5 @@
 //
 // You can specify all the values or you can default the Revision and Build Numbers
 // by using the '*' as shown below:
-[assembly: AssemblyVersion("3.0.0.0")]
-[assembly: AssemblyFileVersion("3.0.0.0")]
+[assembly: AssemblyVersion("3.0.3.0")]
+[assembly: AssemblyFileVersion("3.0.3.0")]

tests/NHapi.NUnit/NHapi.NUnit.csproj

@@ -73,7 +73,8 @@
     <Copy SourceFiles="App.config" DestinationFiles="$(OutDir)\testhost.dll.config" />
     <Copy SourceFiles="App.config" DestinationFiles="$(OutDir)\testhost.x86.dll.config" />
     <!-- Rider -->
-    <Copy SourceFiles="App.config" DestinationFiles="$(OutDir)\ReSharperTestRunner64.dll.config"/>
+    <Copy SourceFiles="App.config" DestinationFiles="$(OutDir)\ReSharperTestRunner.dll.config" />
+    <Copy SourceFiles="App.config" DestinationFiles="$(OutDir)\ReSharperTestRunner64.dll.config" />
   </Target>
 
 </Project>