Skip to content

Commit c16d1f2

Browse files
authored
Merge pull request neo4j#708 from oskarhane/fix-false-positive-rel
Add transport types to use when transferring results ww -> main thread
2 parents 52f70e2 + 1c6f029 commit c16d1f2

File tree

10 files changed

+422
-484
lines changed

10 files changed

+422
-484
lines changed

__mocks__/neo4j.js

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,8 @@ integerFn.prototype.toString = function () {
2727

2828
var out = {
2929
v1: {
30-
Int: integerFn,
3130
isInt: function (val) {
32-
return val instanceof integerFn
31+
return val instanceof out.v1.Integer
3332
},
3433
types: {
3534
Node: function Node (id, labels, properties) {
@@ -56,7 +55,7 @@ var out = {
5655
this.end = end
5756
}
5857
},
59-
Integer: function Integer ({ low, high }) {
58+
Integer: function Integer (low, high) {
6059
this.low = low
6160
this.high = high
6261
}
@@ -78,6 +77,16 @@ out.v1.types.PathSegment.prototype.toString = function () {
7877
out.v1.Integer.prototype.toInt = function () {
7978
return this.low
8079
}
81-
out.v1.int = val => new out.v1.Integer(val)
80+
out.v1.Integer.prototype.toString = function () {
81+
return this.low
82+
}
83+
out.v1.Int = out.v1.Integer
84+
out.v1.int = val => {
85+
if (val /* is compatible */ instanceof out.v1.Integer) return val
86+
if (typeof val === 'number') return new out.v1.Integer(val)
87+
if (typeof val === 'string') return new out.v1.Integer(val)
88+
// Throws for non-objects, converts non-instanceof Integer:
89+
return new out.v1.Integer(val.low, val.high)
90+
}
8291

8392
module.exports = out

package.json

Lines changed: 12 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,10 @@
1515
"apiVersion": "^1.2.0"
1616
},
1717
"scripts": {
18-
"start": "webpack-dashboard -t 'Neo4j Browser' -- webpack-dev-server --colors --no-info",
19-
"starts": "webpack-dashboard -t 'Neo4j Browser' -- webpack-dev-server --https --colors --no-info",
18+
"start":
19+
"webpack-dashboard -t 'Neo4j Browser' -- webpack-dev-server --colors --no-info",
20+
"starts":
21+
"webpack-dashboard -t 'Neo4j Browser' -- webpack-dev-server --https --colors --no-info",
2022
"startnodash": "webpack-dev-server --colors --no-info",
2123
"precommit": "lint-staged",
2224
"format": "prettier-eslint 'src/**/!(*.min).js' 'src/**/*.jsx' --write",
@@ -27,24 +29,20 @@
2729
"build": "rm -rf ./dist && NODE_ENV=\"production\" webpack",
2830
"prepare-jar": "node ./scripts/prepare-mvn-package.js",
2931
"jar": "yarn build && mvn package",
30-
"version-pom": "node ./scripts/set-pom-version.js -f ./pom.xml -v $npm_package_version",
32+
"version-pom":
33+
"node ./scripts/set-pom-version.js -f ./pom.xml -v $npm_package_version",
3134
"version": "npm run version-pom && git add ./pom.xml"
3235
},
3336
"lint-staged": {
3437
"linters": {
35-
"*.{js,jsx}": [
36-
"prettier-eslint --write",
37-
"git add"
38-
]
38+
"*.{js,jsx}": ["prettier-eslint --write", "git add"]
3939
}
4040
},
4141
"jest": {
42-
"testPathIgnorePatterns": [
43-
".jsx$",
44-
"/e2e_tests/"
45-
],
42+
"testPathIgnorePatterns": [".jsx$", "/e2e_tests/"],
4643
"moduleNameMapper": {
47-
"\\.(jpg|jpeg|png|gif|eot|otf|webp|svg|ttf|woff|woff2|mp4|webm|wav|mp3|m4a|aac|oga|html)$": "<rootDir>/__mocks__/fileMock.js",
44+
"\\.(jpg|jpeg|png|gif|eot|otf|webp|svg|ttf|woff|woff2|mp4|webm|wav|mp3|m4a|aac|oga|html)$":
45+
"<rootDir>/__mocks__/fileMock.js",
4846
"\\.(css|less)$": "<rootDir>/__mocks__/styleMock.js",
4947
"neo4j": "<rootDir>/__mocks__/neo4j.js",
5048
"^react-dom/server$": "preact-render-to-string",
@@ -56,10 +54,7 @@
5654
"^browser-components(.*)$": "<rootDir>/src/browser/components$1",
5755
"worker-loader": "<rootDir>/__mocks__/workerLoaderMock.js"
5856
},
59-
"modulePaths": [
60-
"<rootDir>/src",
61-
"<rootDir>/src/shared"
62-
]
57+
"modulePaths": ["<rootDir>/src", "<rootDir>/src/shared"]
6358
},
6459
"devDependencies": {
6560
"autoprefixer": "^7.1.4",
@@ -118,7 +113,7 @@
118113
"redux-mock-store": "^1.2.3",
119114
"style-loader": "^0.18.1",
120115
"url-loader": "^0.5.8",
121-
"webpack": "^3.5.6",
116+
"webpack": "^3.11.0",
122117
"webpack-bundle-analyzer": "^2.9.0",
123118
"webpack-dashboard": "^0.4.0",
124119
"webpack-dev-server": "^2.7.1",

0 commit comments

Comments
 (0)