Solution for construct enum from inherited enum with incompatible value #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

mnapoli merged 1 commit into myclabs:master from KartaviK:hotfix/enum-inheritance-compatibility

Aug 19, 2019

Contributor

KartaviK commented Aug 12, 2019 •

edited

Loading

Solution for #95

But the main principle for building architecture with enum is do not change based constants for inherited enum


          Resolve constructing base enum from inherited enum with invalid value

3359da8

mnapoli added the bug label

KartaviK mentioned this pull request

Construction of enum object with invalid value is possible #95

Closed

Member

mnapoli commented Aug 12, 2019

Oh that's really clever and simple, I love it!

I'm going to leave this open for a little while to let time for others to review, but that looks good to me.

mnapoli merged commit 45f01ad into myclabs:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug