Drop support for PHP 5.3 #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 3, 2018
|
It's not backwards incompatible, it just means that PHP 5.3 users won't get any new releases beyond the current version. |
Agreed. Releasing a new major version for this package would be really detrimental as it would create many conflicts downstream. I intend on releasing a new minor version: those still using PHP 5.3 will not have this new version installed. |
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in issue #67 this PR drops support for PHP 5.3 as preparation for the implementation of the
JsonSerializableinterface.This change probably requires a new major release because it's a backwards incompatible change. However, this release can wait for the next PR because just now there are no new features to release.