-
-
Notifications
You must be signed in to change notification settings - Fork 132
suppress some psalm reported errors #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -69,15 +69,25 @@ public function __construct($value) | |
$value = $value->getValue(); | ||
} | ||
|
||
/** @psalm-suppress ImplicitToStringCast assertValidValueReturningKey returns always a string but psalm has currently an issue here */ | ||
$this->key = static::assertValidValueReturningKey($value); | ||
|
||
/** @psalm-var T */ | ||
$this->value = $value; | ||
} | ||
|
||
/** | ||
* This method exists only for the compatibility reason when deserializing a previously serialized version | ||
* that didn't had the key property | ||
*/ | ||
public function __wakeup() | ||
{ | ||
/** @psalm-suppress DocblockTypeContradiction key can be null when deserializing an enum without the key */ | ||
if ($this->key === null) { | ||
/** | ||
* @psalm-suppress InaccessibleProperty key is not readonly as marked by psalm | ||
* @psalm-suppress PossiblyFalsePropertyAssignmentValue deserializing a case that was removed | ||
*/ | ||
$this->key = static::search($this->value); | ||
} | ||
} | ||
|
@@ -215,6 +225,7 @@ public static function isValid($value) | |
* | ||
* @psalm-pure | ||
* @psalm-assert T $value | ||
* @param mixed $value | ||
*/ | ||
public static function assertValidValue($value): void | ||
{ | ||
|
@@ -226,6 +237,8 @@ public static function assertValidValue($value): void | |
* | ||
* @psalm-pure | ||
* @psalm-assert T $value | ||
* @param mixed $value | ||
* @return string | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here, why add this? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here. The @return I guess it's just the PhpStorm complaining about. |
||
*/ | ||
private static function assertValidValueReturningKey($value): string | ||
{ | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why add this parameter docblock?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a
MissingParamType
psalm error.https://psalm.dev/docs/running_psalm/issues/MissingParamType/