Added new named constructor to create enum from mixed #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelpetri
force-pushed
the
feature/add-create-from-mixed
branch
2 times, most recently
from
d33c58e to
9343c3f
Compare
andrew-demb
reviewed
Feb 10, 2021
michaelpetri
force-pushed
the
feature/add-create-from-mixed
branch
from
9343c3f to
5cdc5da
Compare
drealecs
reviewed
Feb 10, 2021
The current implementation of Enum requires to pass a valid enum value to class constructor. With this new named constructor we can just pass any value to enum and get an instance or unexpected value exception.
michaelpetri
force-pushed
the
feature/add-create-from-mixed
branch
from
5cdc5da to
bd92d06
Compare
Ocramius
approved these changes
Feb 12, 2021
mnapoli
approved these changes
Feb 12, 2021
drealecs
reviewed
Feb 15, 2021
| * @psalm-pure | ||
| * @psalm-assert T $value | ||
| */ | ||
| public static function assertValidValue($value): void |
There was a problem hiding this comment.
I propose to not extend the API also with this static method and have it private.
I wanted to change how it behaves here: #136 (comment)
There was a problem hiding this comment.
I understand what you say. Yes, it can be useful as a public API as well to just validate without creating the instances.
It would have help a bit in making sure is_array or array_search are not called in constructor more than once when object is created,
is_array is already called twice when from() is used and I was thinking that should also be optimized.
There was a problem hiding this comment.
And this endpoint can be made completely independent from the ctor in the patch doing the perf optimization, no?
Ocramius
added a commit
to Ocramius/php-enum-1
that referenced
this pull request
Mar 11, 2021
…ound to any template These functions had a `T` template parameter in them, but this `T` is completely decoupled from the one defined at class-level (and therefore at `Enum` instance level, rather than statically): * `Enum::from()` * `Enum::isValid()` * `Enum::assertValidValue()` * `Enum::assertValidValueReturningKey()` (internal detail) In practice, this means that myclabs#135 (Added new named constructor to create enum from mixed) was not a valid approach to infer types for enumerable values, when performed statically. A new approach will be attempted, but the current one will likely need to be scrapped for now. In practice, `@psalm-assert`, `@psalm-assert-if-true` and `@psalm-return static<T>` had no effect on these methods, due to a design-level issue that wasn't spotted (by myself either) at review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of Enum requires to pass a valid enum value to class constructor. With this new named constructor we can just pass any value to enum and get an instance or unexpected value exception. In the end it's like the class constructor except for it makes psalm happy.