Skip to content

__callStatic should probably be @psalm-pure #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Ocramius opened this issue Jan 21, 2021 · 1 comment · Fixed by #138
Closed

__callStatic should probably be @psalm-pure #134

Ocramius opened this issue Jan 21, 2021 · 1 comment · Fixed by #138

Comments

@Ocramius
Copy link
Contributor

php-enum/src/Enum.php

Line 223 in 616601d

public static function __callStatic($name, $arguments)

@mnapoli
Copy link
Member

mnapoli commented Jan 21, 2021

👍 I definitely trust your judgement on this, I'm not familiar enough with the pure annotations.

Ocramius added a commit to Ocramius/php-enum-1 that referenced this issue Feb 12, 2021
@Ocramius
Fix myclabs#134 by marking Enum::__callStatic as @psalm-pure
db6a2a8 
To achieve proper static analysis coverage:

 * `vimeo/psalm` has been updated
 * a new `static-analysis` dir has been added (to test static analysis properties **only**)
 * impure `$this` usages in `Enum` have been ignored in static analysis checks
 * PHP version support has been upgraded from `>=7.1` to `^7.3 || ^8.0`
 * PHPUnit version has been upgraded to its latest and greatest

Fixes myclabs#134
@Ocramius Ocramius mentioned this issue Feb 12, 2021
Merged
@drealecs drealecs mentioned this issue Feb 14, 2021
Merged
mnapoli added a commit that referenced this issue Feb 15, 2021
@mnapoli
Merge pull request #138 from Ocramius/feature/#134-mark-__callStatic-…
46cf3d8 
…as-pure

Fix #134 by marking `Enum::__callStatic` as `@psalm-pure`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #134 by marking Enum::__callStatic as @psalm-pure Ocramius/php-enum-1
2 participants
@Ocramius @mnapoli