MapperScannerConfigurer cause early initialize bean

[huangxfchn]

description

Since 2.0.2, MapperScannerConfigurer has changed a lot, but it brings bug.

Mapperscannerconfigurer belongs to beandefinitionregistrypostprocessor. During this period, the bean has not been initialized, but the processpropertyplaceholders() method traverses the entire ApplicationContext, leading to the bean being instantiated in advance, because ApplicationContext.getBeansOfType() will be created in advance by default.

If the bean is instantiated in advance, it will cause some problems, such as unable to rely on injection, failure to get configuration parameters, etc

code

MapperScannerConfigurer.java

public void postProcessBeanDefinitionRegistry(BeanDefinitionRegistry registry) {
    if (this.processPropertyPlaceHolders) {
      processPropertyPlaceHolders();
    }
    //……
}

private void processPropertyPlaceHolders() {
	Map<String, PropertyResourceConfigurer> prcs = applicationContext.getBeansOfType(PropertyResourceConfigurer.class);
	//……
}

[kazuki43zoo]

@huangxfchn Thanks for your reporting!!

Could your provide a project for reproducing bug via GitHub?

[huangxfchn]

@huangxfchn Thanks for your reporting!!

Could your provide a project for reproducing bug via GitHub?

OK, tomorrow, please. I'm off work today.

[kazuki43zoo]

thx!!

[xiongmaodada]

@kazuki43zoo hi, I provide a project for reproducing bug via Github.

when run this demo, result is as follow:

========consumerConfig is null 

tag: factoryBean consumerFactoryBean object without injecting consumerConfig parameter.

while modify mybatis-spring-boot-starter version

dependency>
            <groupId>org.mybatis.spring.boot</groupId>
            <artifactId>mybatis-spring-boot-starter</artifactId>
            <version>2.0.1</version>
        </dependency>

then running this demo, result is as follow:

========consumerConfig is not null 

tag: factoryBean consumerFactoryBean object with injecting consumerConfig successfully.

[huangxfchn]

@kazuki43zoo hi, I provide a project for reproducing bug via Github.

when run this demo, result is as follow:

========consumerConfig is null 

tag: factoryBean consumerFactoryBean object without injecting consumerConfig parameter.

while modify mybatis-spring-boot-starter version

dependency>
            <groupId>org.mybatis.spring.boot</groupId>
            <artifactId>mybatis-spring-boot-starter</artifactId>
            <version>2.0.1</version>
        </dependency>

then running this demo, result is as follow:

========consumerConfig is not null 

tag: factoryBean consumerFactoryBean object with injecting consumerConfig successfully.

Wowo, Thank you very much!

[huangxfchn]

like this: spring boot test cause early FactoryBean instantiation #15898

[xiongmaodada]

the above address is as followed：

No results matched your search.

[huangxfchn]

the above address is as followed：

No results matched your search.

Sorry, I made a mistake. The correct link: spring boot issue#15898

[kazuki43zoo]

@huangxfchn @xiongmaodada

Thanks for your contribution!! This problem which potentially existed from previous versions, became apparent with the support of gh-376.
For resolve this problem, I've fixed to prevent eager initialization of bean when retrieve PropertyResourceConfigurer on the MapperScannerConfigurer.

The 2.0.5-SNAPSHOT is available via OSS NEXUS snapshot repository.

Workaround until released the 2.0.5

This problem can prevent by set the processPropertyPlaceHolders to false as follow:

@Configuration
static class MyBatisConfig {
	@Bean
	MapperScannerConfigurer mapperScannerConfigurer() {
		MapperScannerConfigurer configurer = new MapperScannerConfigurer();
		configurer.setBasePackage("com.example.mybatis");
		configurer.setProcessPropertyPlaceHolders(false); // set to 'false'
		return configurer;
	}
}

Note

The mybatis-spring-boot-starter 2.1.3-SNAPSHOT is available via OSS NEXUS snapshot repository.

[ryou-ks]

there is an error happened when I used mybatis-spring-2.0.5/spring 5.2.6/mybatis3.5.5 as follow:
org.springframework.beans.factory.NoSuchBeanDefinitionException: No bean named 'targetDataSource' available

How to solve this problem?

---

my spring xml code

<bean>
   <bean id="propertyConfigurer" class="org.springframework.beans.factory.config.PropertyOverrideConfigurer">
      <property name="locations" />
	<list>
           <value>classpath:mybatis/database.properties<value/>
        <list>
      <property/>
   </bean>
   <bean id="targetDataSource" class="org.springframework.jndi.jndiObjectFactoryBean">
 <beans/>


---------------------------------------------------------------------------------------------------
my properties (database.properties)
targetDataSource.jndiName=aa/bb