Skip to content

fix mistranslation #2594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2022
Merged

fix mistranslation #2594

merged 1 commit into from
Sep 12, 2022

Conversation

DonggeonMoon
Copy link
Contributor

@DonggeonMoon DonggeonMoon commented Jun 25, 2022

I found a discrepancy between English version and Korean one. I don't know why but the previous version explained built-in type aliases as "case-sensitive" in Korean. I guess there were some changes in mybatis feature, or just a mistake. Plus, I added translation for "note the special handling of primitives due to the overloaded names".

I found an discrepancy between English version and Korean one. I don't know why but the previous version explained built-in type aliases as "case-sensitive" in Korean. I guess there were some changes in mybatis version, or just a mistake. Plus, I added translation for "note the special handling of primitives due to the overloaded names" in English version.
Copy link

@jwkim86 jwkim86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기 일반 자바 타입에 대한 많은 내장 타입 별칭이 있습니다. 그들은 모두 대소문자를 구별하지 않으며, 오버로드된 이름 때문에 원시 타입이 특별 처리되는 것에 주의하세요.

@@ -666,8 +666,7 @@ public class Author {
...
}
]]></source>
<p>공통의 자바타입에 대해서는 내장된 타입 별칭이 있다.
이 모두 대소문자를 가린다.</p>
<p>공통 자바 타입을 위한 여러 내장 타입 별칭이 존재한다. 이들은 대소문자를 구별하지 않으며, 오버로딩된 이름 때문에 원시형 타입은 특별 취급된다는 것을 주의해라.</p>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기 일반 자바 타입에 대한 많은 내장 타입 별칭이 있다. 그들은 모두 대소문자를 구별하지 않으며, 원시 타입은 오버로드된 이름 때문에 특별 처리되는 것에 주의하라.

요것은 어떠신가요?

@harawata harawata added the documentation Indicates a changing on documentation(reference or javadoc) label Sep 12, 2022
@harawata harawata self-assigned this Sep 12, 2022
@harawata harawata added this to the 3.5.11 milestone Sep 12, 2022
@harawata harawata merged commit ca15692 into mybatis:master Sep 12, 2022
@harawata
Copy link
Member

Thank you @DonggeonMoon @jwkim86 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌏 doc-ko documentation Indicates a changing on documentation(reference or javadoc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants