Skip to content

Update index.xml #1749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2022
Merged

Update index.xml #1749

merged 1 commit into from
Sep 11, 2022

Conversation

marcobehler
Copy link
Contributor

Hi all,
I'm currently revising my guide on database access in Java ( https://www.marcobehler.com/guides/a-guide-to-accessing-databases-in-java ) and was thinking - with the risk of it being rejected for self promotion - that including it in the 'Introduction' section would help more people get a clearer picture of the whole Java database landscape and where and how MyBatis fits in. At least that's the feedback I got so far.

In any case, thanks for considering!

@@ -40,6 +40,8 @@
Java POJOs
(Plain Old Java Objects) to database records.
</p>
<p>If you are completely new to database access in Java,<a href="https://www.marcobehler.com/guides/a-guide-to-accessing-databases-in-java">https://www.marcobehler.com/guides/a-guide-to-accessing-databases-in-java</a> contains a good overview of the various parts, pieces and options and shows you where exactly MyBatis fits in.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a good place for advertising?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know about connotating it as advertising (for what exactly?).

It is outreach for an article that helped quite a few people so far get a good picture of the Java DB landscape - that's why I think places like the Hibernate or jOOQ documentation are also already linking to it.

Copy link
Contributor

@awxiaoxian2020 awxiaoxian2020 Apr 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a good place for advertising?

Although I also think it is not appropriate to add a personal website that is not widely recognized in MyBatis document, I think there should be hints for beginners in the document by other ways. ref: #2480

@hazendaz
Copy link
Member

idk, kind of ok with this, it is helpful based on what I saw and its kept up to date. @harawata , WDYT?

@harawata
Copy link
Member

@hazendaz ,

I personally prefer not to have external links, but I'm OK with it if you think it's useful.

@awxiaoxian2020
Copy link
Contributor

@harawata @hazendaz I still suggest some contents about JDBC in Oracle should/could be added in our doc.

@hazendaz
Copy link
Member

@awxiaoxian2020 I agree with your thinking. Is that maybe something you can work up? I'm sure the docs need a lot of love they don't generally get.

@harawata I think in this specific case, we probably would never go to so great of detail to discuss alternatives anyways and its laid out nicely enough its not really promoting any one thing over any other thing. And finally, its so little enough here that we can remove at any point later. I think in general for entry level developers it is important to see alternatives like this which further helps them also understand why an organization or team may have made a specific choice along the way.

@hazendaz
Copy link
Member

hazendaz commented Sep 11, 2022

@marcobehler Going to go ahead and accept this. While we have varying concerns on external information such as this, there is certainly value to such information. That said, if for some reason our team feels its not useful later down the road, it could be removed so just putting that out there. In all likelihood it will remain. Thank you!

@hazendaz hazendaz merged commit 00461e7 into mybatis:master Sep 11, 2022
@marcobehler
Copy link
Contributor Author

marcobehler commented Sep 12, 2022

@hazendaz Thank you. (This might pass as the oldest pull request I ever got merged ;) )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants