Test against heredocs to ensure first line gets always counted correctly

Author: Slamdunk

src/StaticAnalysis/ExecutableLinesFindingVisitor.php

@@ -170,7 +170,7 @@ private function getLines(NodeAbstract $node, bool $fromReturns): array
                     $node->left instanceof Node\Expr\Variable ||
                 $node->right instanceof Node\Expr\Variable
                 )) {
-                return [$node->right->getStartLine()];
+                return [$this->getNodeStartLine($node->right)];
             }
 
             return $fromReturns ? $this->getLines($node->right, $fromReturns) : [];

tests/_files/source_with_multiline_constant_return.php

@@ -498,15 +498,19 @@ public function concatWithVar(): string
         $var1 = 'start';
 
         $var1 =
-            'right'
+            <<<'EOF'
+right
+EOF
             .
             $var1
         ;
 
         $var1 =
             $var1
             .
-            'left'
+            <<<'EOF'
+left
+EOF
         ;
 
         return $var1;

tests/tests/Data/RawCodeCoverageDataTest.php

@@ -500,10 +500,10 @@ public function testReturnStatementWithConstantExprOnlyReturnTheLineOfLast(): vo
                 490,
                 498,
                 500,
-                503,
-                506,
-                509, // This is correct: not the line with the $var1, but the right operand of the Concat
-                512,
+                505,
+                508,
+                512, // This is correct: not the line with the $var1, but the right operand of the Concat
+                516,
             ],
             array_keys(RawCodeCoverageData::fromUncoveredFile($file, new ParsingFileAnalyser(true, true))->lineCoverage()[$file])
         );