Skip to content

webstats: deprecate flash player #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jlillis opened this issue Jan 23, 2021 · 5 comments · Fixed by #293
Closed

webstats: deprecate flash player #278

jlillis opened this issue Jan 23, 2021 · 5 comments · Fixed by #293
Assignees
@patrikjuvonen
Labels
refactor resource:webstats web Web related issues
Milestone
1.5.9

Comments

@jlillis
Copy link
Contributor

jlillis commented Jan 23, 2021 •
edited
Loading

Which resource(s) have this problem?
webstats

Describe the bug
The webstats resource uses flash player, which has been discontinued as of this year. This needs to be addressed by either:

  • upgrading the resource
  • deprecating it

To Reproduce
N/A

Expected behavior
N/A

Screenshots
N/A

Version
N/A

Additional context
https://www.adobe.com/products/flashplayer/end-of-life.html
@jlillis jlillis added resource:webmap web Web related issues labels Jan 23, 2021
@qaisjp
Copy link
Contributor

qaisjp commented Jan 23, 2021

My opinion

When you take out the flash parts of webmap, what is left behind?

Can the remainder webmap Lua code be considered salvageable, for a reimplementation of the frontend w/o flash?

  • If so, deprecate (exclude from distributions via mtasa-blue installer configuration), and upgrade in the future.
  • If not, delete the whole resource.

@patrikjuvonen
Copy link
Contributor

I'm going to work on this!

@patrikjuvonen patrikjuvonen self-assigned this Jan 23, 2021
@jlillis
Copy link
Contributor Author

jlillis commented Jan 23, 2021

Had a little brain moment when filing this report - it's webstats that has this issue, not webmap. The webmap resource has it's own problem reported here: #130

@patrikjuvonen
Copy link
Contributor

All web related resources could use some refreshing.

@jlillis
Copy link
Contributor Author

jlillis commented Jan 23, 2021

All web related resources could use some refreshing.

There is a discussion on that topic here: #279

@patrikjuvonen patrikjuvonen changed the title webmap: deprecate flash player webstats: deprecate flash player Jan 24, 2021
@patrikjuvonen patrikjuvonen linked a pull request Feb 13, 2021 that will close this issue
Fix webstats #293
Merged
jlillis pushed a commit that referenced this issue Feb 15, 2021
@patrikjuvonen
webstats: refactor code (#293)
f14920a 
- Use Chart.js
- Refactor code
- Reduce frequency to 5 seconds from 60 seconds
* Fixes #278
@patrikjuvonen patrikjuvonen added this to the 1.5.9 milestone Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@patrikjuvonen patrikjuvonen

Labels
refactor resource:webstats web Web related issues
Projects
None yet
Milestone
1.5.9
Development

Successfully merging a pull request may close this issue.

Fix webstats
3 participants
@qaisjp @jlillis @patrikjuvonen