Skip to content

Fix armor limit and synchronization between client and server #3983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 28, 2025

Conversation

Nico8340
Copy link
Contributor

Fixes #3982

@ghost
Copy link

ghost commented Jan 26, 2025

Just an opinion: Maybe the cap should be 150 and not 100 as this is an original (singleplayer) behaviour.
The max health bug will be fixed after 1.6.1 which means that players will have the original maximum max health(176) instead of 200, so it would be better to have the armor cap raised to 150 as well.

@Nico8340
Copy link
Contributor Author

Just an opinion: Maybe the cap should be 150 and not 100 as this is an original (singleplayer) behaviour. The max health bug will be fixed after 1.6.1 which means that players will have the original maximum max health(176) instead of 200, so it would be better to have the armor cap raised to 150 as well.

That will be in a separate pull request because this change is needed as soon as possible so that cheaters cannot exploit it, and it would also require a deeper modification to the synchronization, which is needed anyway because the current armor sync is inaccurate

@Nico8340
Copy link
Contributor Author

This pull request is fully backward compatible, I tried to keep the number of changes as low as possible so that it can be merged as soon as possible

@Dutchman101 Dutchman101 merged commit 583e675 into multitheftauto:master Jan 28, 2025
MTABot pushed a commit that referenced this pull request Jan 28, 2025
583e675 Fixes #3982: armor limit and synchronization between client and server (#3983)
@botder botder added this to the 1.6.1 milestone Jan 28, 2025
@Nico8340 Nico8340 deleted the armor branch January 28, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Armor value above 100 client side bypasses max armor limit on server
3 participants