This repository was archived by the owner on Oct 19, 2022. It is now read-only.
test: Increase test coverage #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ported tests from #6
| @@ -36,8 +36,7 @@ function Silent () { | |||
| if (msg === protocol) { | |||
| return callback(null, self.duplexStream) | |||
| } else { | |||
| self.duplexStream.end() | |||
There was a problem hiding this comment.
Why remove this call? Closing the stream is the signal that the protocol was not supported in this scenario.
There was a problem hiding this comment.
Because the error means the protocol is not supported?
There was a problem hiding this comment.
Ignore my last message. We don't want to end the stream, just because one (of possible multiple handlers) errors, is my understanding of this.
There was a problem hiding this comment.
It can be interpreted differently, but since there is ambiguity from the spec (as it is more of a implementation details) and I have no strong use case for it to close. Let's continue this way then.
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported tests from #6