full test coverage and benchmarks added

Author: dignifiedquire

benchmarks/hash.js

@@ -0,0 +1,32 @@
+'use strict'
+
+const Benchmark = require('benchmark')
+const multihashing = require('../src')
+
+const suite = new Benchmark.Suite('multihashing')
+const list = []
+
+const algs = ['sha1', 'sha2-256', 'sha2-512', 'sha3']
+
+algs.forEach((alg) => {
+  suite.add(alg, function (d) {
+    const buf = new Buffer(10 * 1024)
+    buf.fill(Math.ceil(Math.random() * 100))
+
+    multihashing(buf, alg, (err, res) => {
+      if (err) throw err
+      list.push(res)
+      d.resolve()
+    })
+  }, {
+    defer: true
+  })
+})
+suite
+.on('cycle', (event) => {
+  console.log(String(event.target))
+})
+// run async
+.run({
+  async: true
+})

package.json

@@ -5,7 +5,8 @@
   "main": "lib/index.js",
   "jsnext:main": "src/index.js",
   "browser": {
-    "./src/crypto.js": "./src/crypto-browser.js"
+    "./src/crypto.js": "./src/crypto-browser.js",
+    "./lib/crypto.js": "./lib/crypto-browser.js"
   },
   "scripts": {
     "test": "PHANTOM=off aegir-test",
@@ -17,7 +18,8 @@
     "release-major": "PHANTOM=off aegir-release major",
     "build": "aegir-build",
     "coverage": "aegir-coverage",
-    "coverage-publish": "aegir-coverage publish"
+    "coverage-publish": "aegir-coverage publish",
+    "bench": "node benchmarks/hash.js"
   },
   "pre-commit": [
     "lint",
@@ -42,6 +44,7 @@
   },
   "devDependencies": {
     "aegir": "^8.1.0",
+    "benchmark": "^2.1.1",
     "chai": "^3.5.0",
     "pre-commit": "^1.1.2"
   },

src/index.js

@@ -11,6 +11,10 @@ function Multihashing (buf, func, length, callback) {
     length = undefined
   }
 
+  if (!callback) {
+    throw new Error('Missing callback')
+  }
+
   Multihashing.digest(buf, func, length, (err, digest) => {
     if (err) {
       return callback(err)

test/index.spec.js

@@ -60,9 +60,49 @@ describe('multihashing', () => {
     })
   })
 
-  it('throws on non implemented func', () => {
-    multihashing(new Buffer('beep boop'), 'blake2b', (err) => {
-      expect(err.message).to.match(/not yet supported/)
+  it('digest only, without length', (done) => {
+    const buf = new Buffer('beep boop')
+
+    multihashing.digest(buf, 'sha2-256', (err, digest) => {
+      if (err) {
+        return done(err)
+      }
+
+      expect(
+        digest
+      ).to.be.eql(
+        new Buffer('90ea688e275d580567325032492b597bc77221c62493e76330b85ddda191ef7c', 'hex')
+      )
+
+      done()
+    })
+  })
+
+  describe('invalid arguments', () => {
+    it('returns an error on non implemented func', (done) => {
+      multihashing(new Buffer('beep boop'), 'blake2b', (err) => {
+        expect(err.message).to.match(/not yet supported/)
+        done()
+      })
+    })
+
+    it('digest only, with length, returns error on non implmented func', (done) => {
+      multihashing.digest(new Buffer('beep boop'), 'blake2b', 10, (err) => {
+        expect(err.message).to.match(/not yet supported/)
+        done()
+      })
+    })
+
+    it('throws on missing callback', () => {
+      expect(
+        () => multihashing(new Buffer('beep'), 'sha3')
+      ).to.throw(/Missing callback/)
+    })
+
+    it('digest only, throws on missing callback', () => {
+      expect(
+        () => multihashing.digest(new Buffer('beep'), 'sha3')
+      ).to.throw(/Missing callback/)
     })
   })
 })