Skip to content
This repository was archived by the owner on Aug 24, 2021. It is now read-only.

chore: update examples to use Uint8Arrays #62

Merged
merged 3 commits into from
Jul 31, 2020
Merged

chore: update examples to use Uint8Arrays #62

merged 3 commits into from
Jul 31, 2020

Conversation

Gozala
Copy link
Contributor

@Gozala Gozala commented Jul 25, 2020

Forgot to reflect changes from #61 in readme 🥺

Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine. I'm just a tiny bit hesitant to remove the word "buffer" entirely. It's technically correct, but I'm not sure how widely understood the Buffer = Uint8Array subclass is in the backend community that mostly gets to ignore these nuances.

Copy link
Member

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a tiny correction in the spirit of banishing the word buffer.

vmx and others added 2 commits July 31, 2020 13:00
Co-authored-by: Alex Potsides <[email protected]>
Co-authored-by: Alex Potsides <[email protected]>
@vmx vmx merged commit 257d003 into master Jul 31, 2020
@vmx vmx deleted the readme-update branch July 31, 2020 11:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants