Fixups

Signed-off-by: Ettore Di Giacinto <[email protected]>

Author: mudler

core/gallery/importers/llama-cpp.go

@@ -70,9 +70,11 @@ func (i *LlamaCPPImporter) Import(details Details) (gallery.ModelConfig, error)
 		return gallery.ModelConfig{}, err
 	}
 	preferencesMap := make(map[string]any)
-	err = json.Unmarshal(preferences, &preferencesMap)
-	if err != nil {
-		return gallery.ModelConfig{}, err
+	if len(preferences) > 0 {
+		err = json.Unmarshal(preferences, &preferencesMap)
+		if err != nil {
+			return gallery.ModelConfig{}, err
+		}
 	}
 
 	name, ok := preferencesMap["name"].(string)

core/startup/model_preload_test.go

@@ -42,7 +42,9 @@ var _ = Describe("Preload test", func() {
 			url := "https://raw.githubusercontent.com/mudler/LocalAI-examples/main/configurations/phi-2.yaml"
 			fileName := fmt.Sprintf("%s.yaml", "phi-2")
 
-			galleryService := services.NewGalleryService(&config.ApplicationConfig{}, ml)
+			galleryService := services.NewGalleryService(&config.ApplicationConfig{
+				SystemState: systemState,
+			}, ml)
 			galleryService.Start(ctx, config.NewModelConfigLoader(tmpdir), systemState)
 
 			err := InstallModels(ctx, galleryService, []config.Gallery{}, []config.Gallery{}, systemState, ml, true, true, func(s1, s2, s3 string, f float64) {
@@ -60,17 +62,22 @@ var _ = Describe("Preload test", func() {
 			url := "huggingface://TheBloke/TinyLlama-1.1B-Chat-v0.3-GGUF/tinyllama-1.1b-chat-v0.3.Q2_K.gguf"
 			fileName := fmt.Sprintf("%s.gguf", "tinyllama-1.1b-chat-v0.3.Q2_K")
 
-			galleryService := services.NewGalleryService(&config.ApplicationConfig{}, ml)
+			galleryService := services.NewGalleryService(&config.ApplicationConfig{
+				SystemState: systemState,
+			}, ml)
+			galleryService.Start(ctx, config.NewModelConfigLoader(tmpdir), systemState)
 
 			err := InstallModels(ctx, galleryService, []config.Gallery{}, []config.Gallery{}, systemState, ml, true, true, func(s1, s2, s3 string, f float64) {
 				fmt.Println(s1, s2, s3, f)
 			}, url)
 			Expect(err).ToNot(HaveOccurred())
 
 			resultFile := filepath.Join(tmpdir, fileName)
+			dirs, err := os.ReadDir(tmpdir)
+			Expect(err).ToNot(HaveOccurred())
 
 			_, err = os.Stat(resultFile)
-			Expect(err).ToNot(HaveOccurred())
+			Expect(err).ToNot(HaveOccurred(), fmt.Sprintf("%+v", dirs))
 		})
 	})
 })