Nodes: consume labels() when used, to prevent duplicate uniform names. (#26822)

aardgoose · aardgoose · web-flow · commit aa7bec9ab948 · 2023-09-22T16:47:46.000-03:00
Co-authored-by: aardgoose &lt;angus.sawyer@email.com&gt;
diff --git a/examples/jsm/nodes/core/UniformNode.js b/examples/jsm/nodes/core/UniformNode.js
@@ -39,6 +39,8 @@ class UniformNode extends InputNode {
 		const nodeUniform = builder.getUniformFromNode( sharedNode, sharedNodeType, builder.shaderStage, builder.context.label );
 		const propertyName = builder.getPropertyName( nodeUniform );
 
+		if ( builder.context.label !== undefined ) delete builder.context.label;
+
 		return builder.format( propertyName, type, output );
 
 	}

Original file line number	Diff line number	Diff line change
`@@ -39,6 +39,8 @@ class UniformNode extends InputNode {`
`39`	`39`	`const nodeUniform = builder.getUniformFromNode( sharedNode, sharedNodeType, builder.shaderStage, builder.context.label );`
`40`	`40`	`const propertyName = builder.getPropertyName( nodeUniform );`
`41`	`41`
	`42`	`+ if ( builder.context.label !== undefined ) delete builder.context.label;`
	`43`	`+`
`42`	`44`	`return builder.format( propertyName, type, output );`
`43`	`45`
`44`	`46`	`}`