fix: Fenix does not require WRITE_EXTERNAL_STORAGE permission to be granted (#2306)

Author: rpl

src/extension-runners/firefox-android.js

@@ -411,12 +411,10 @@ export class FirefoxAndroidExtensionRunner {
     log.debug('Checking read/write permissions needed for web-ext' +
               `on ${selectedFirefoxApk}...`);
 
-    // Runtime permission needed to be able to run Firefox on a temporarily created profile
-    // on android versions >= 23 (Android Marshmallow, which is the first version where
-    // these permissions are optional and have to be granted explicitly).
+    // Runtime permissions needed to Firefox to be able to access the
+    // xpi file uploaded to the android device or emulator.
     const requiredPermissions = [
       'android.permission.READ_EXTERNAL_STORAGE',
-      'android.permission.WRITE_EXTERNAL_STORAGE',
     ];
 
     await adbUtils.ensureRequiredAPKRuntimePermissions(

tests/unit/test-extension-runners/test.firefox-android.js

@@ -959,13 +959,12 @@ describe('util/extension-runners/firefox-android', () => {
              fakeADBUtils.ensureRequiredAPKRuntimePermissions,
              'emulator-1', 'org.mozilla.firefox', [
                'android.permission.READ_EXTERNAL_STORAGE',
-               'android.permission.WRITE_EXTERNAL_STORAGE',
              ]
            );
 
            sinon.assert.callOrder(
              fakeADBUtils.getAndroidVersionNumber,
-             fakeADBUtils.ensureRequiredAPKRuntimePermissions
+             fakeADBUtils.ensureRequiredAPKRuntimePermissions,
            );
          }