When logging error also log the callstack and in case async task fail cancel the rest of the tasks but continue execution. (#86)

Author: abpostelnicu

libmozevent/bus.py

@@ -98,7 +98,7 @@ async def receive(self, name: str):
             try:
                 return pickle.loads(payload)
             except Exception as e:
-                logger.error("Bad redis payload", error=str(e))
+                logger.error("Bad redis payload", error=str(e), exc_info=True)
                 await asyncio.sleep(1)
                 return
 

libmozevent/mercurial.py

@@ -218,7 +218,11 @@ def get_author(commit):
                     user=user.encode("utf-8"),
                 )
             except Exception as e:
-                logger.error("Failed to apply patch: {}".format(e), phid=patch.phid)
+                logger.error(
+                    "Failed to apply patch: {}".format(e),
+                    phid=patch.phid,
+                    exc_info=True,
+                )
                 raise
 
     def add_try_commit(self, build):
@@ -338,7 +342,10 @@ async def run(self):
 
             else:
                 logger.error(
-                    "Unsupported repository", repo=build.repo_phid, build=build
+                    "Unsupported repository",
+                    repo=build.repo_phid,
+                    build=build,
+                    exc_info=True,
                 )
 
     def is_commit_skippable(self, build):
@@ -378,7 +385,8 @@ def get_status():
         while status := get_status() != "open":
             if (datetime.utcnow() - start).seconds >= TRY_STATUS_MAX_WAIT:
                 logger.error(
-                    f"Try tree status still closed after {TRY_STATUS_MAX_WAIT} seconds, skipping"
+                    f"Try tree status still closed after {TRY_STATUS_MAX_WAIT} seconds, skipping",
+                    exc_info=True,
                 )
                 break
             logger.warning(

libmozevent/utils.py

@@ -51,11 +51,10 @@ async def _run():
         try:
             await tasks_group
         except Exception as e:
-            log.error("Failure while running async tasks", error=str(e))
+            log.error("Failure while running async tasks", error=str(e), exc_info=True)
             # When ANY exception from one of the awaitables
             # make sure the other awaitables are cancelled
             tasks_group.cancel()
-            raise e
 
     try:
         event_loop.run_until_complete(_run())
@@ -101,7 +100,9 @@ def _log_process(output, name):
 
     out, err = proc.communicate()
     if proc.returncode != 0:
-        log.error("Mercurial {} failure".format(main_cmd), out=out, err=err)
+        log.error(
+            "Mercurial {} failure".format(main_cmd), out=out, err=err, exc_info=True
+        )
         raise hglib.error.CommandError(cmd, proc.returncode, out, err)
 
     return out

libmozevent/web.py

@@ -74,7 +74,7 @@ async def create_code_review(self, request):
             build = PhabricatorBuild(request)
             await self.bus.send(self.queue_name, build)
         except Exception as e:
-            logger.error(str(e), path=request.path_qs)
+            logger.error(str(e), path=request.path_qs, exc_info=True)
             raise web.HTTPBadRequest(text=str(e))
 
         logger.info("Queued new build", build=str(build))

tests/test_utils.py

@@ -81,20 +81,3 @@ async def await_blpop(*args):
     message = pickle.dumps("message", protocol=pickle.HIGHEST_PROTOCOL)
 
     assert redis_queue == [(queue_name, message)]
-
-    async def deadly_task():
-        await bus.receive("input")
-        # Ensure the message has been consumed
-        assert redis_queue == []
-        # Raise an unexpected error or send a TERM signal to itself
-        task_side_effect()
-        await asyncio.sleep(10)
-
-    with pytest.raises(expected_exception):
-        utils.run_tasks([deadly_task()], bus_to_restore=bus)
-
-    if expected_exception == asyncio.CancelledError:
-        # In case of a SIGTERM, the message has been restored in the queue
-        assert redis_queue == [(queue_name, message)]
-    else:
-        assert redis_queue == []