Update pre-commit repositories and fix some new linting issues

Author: marco-c

.pre-commit-config.yaml

@@ -4,15 +4,15 @@ repos:
     hooks:
       - id: seed-isort-config
   - repo: https://github.com/timothycrosley/isort
-    rev: 5.9.3
+    rev: 5.10.1
     hooks:
       - id: isort
   - repo: https://github.com/ambv/black
-    rev: 21.9b0
+    rev: 22.1.0
     hooks:
       - id: black
   - repo: https://github.com/pre-commit/mirrors-prettier
-    rev: v2.4.0
+    rev: v2.6.0
     hooks:
       - id: prettier
         exclude: ^tests/|libmozdata/modules.json
@@ -26,7 +26,7 @@ repos:
           - "flake8-debugger==3.1.0"
           - "flake8-mypy==17.8.0"
   - repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v4.0.1
+    rev: v4.1.0
     hooks:
       - id: check-ast
       - id: check-docstring-first
@@ -52,11 +52,11 @@ repos:
       - id: codespell
         exclude: libmozdata/modules.json
   - repo: https://github.com/marco-c/taskcluster_yml_validator
-    rev: v0.0.7
+    rev: v0.0.9
     hooks:
       - id: taskcluster_yml
   - repo: https://github.com/asottile/yesqa
-    rev: v1.2.3
+    rev: v1.3.0
     hooks:
       - id: yesqa
   - repo: meta

libmozdata/utils.py

@@ -295,7 +295,7 @@ def get_monday_sunday(date):
 def mean_stddev(x):
     N = len(x)
     m = sum(x) / N
-    v = sum([xi ** 2 for xi in x]) / N - m ** 2
+    v = sum([xi**2 for xi in x]) / N - m**2
     e = math.sqrt(v)
 
     return m, e

tests/test_bugzilla.py

@@ -25,11 +25,11 @@ def bughandler(bug, data):
         bugzilla.Bugzilla(12345, bughandler=bughandler, bugdata=bug).get_data().wait()
 
         self.assertEqual(bug["id"], 12345)
-        self.assertEqual(bug["resolution"], u"FIXED")
-        self.assertEqual(bug["assigned_to"], u"[email protected]")
+        self.assertEqual(bug["resolution"], "FIXED")
+        self.assertEqual(bug["assigned_to"], "[email protected]")
         self.assertEqual(
             bug["summary"],
-            u"[DOGFOOD] Unable to Forward a message received as an Inline page or an attachment",
+            "[DOGFOOD] Unable to Forward a message received as an Inline page or an attachment",
         )
 
     @responses.activate
@@ -43,18 +43,18 @@ def bughandler(bug, data):
         ).get_data().wait()
 
         self.assertEqual(bugs[12345]["id"], 12345)
-        self.assertEqual(bugs[12345]["resolution"], u"FIXED")
-        self.assertEqual(bugs[12345]["assigned_to"], u"[email protected]")
+        self.assertEqual(bugs[12345]["resolution"], "FIXED")
+        self.assertEqual(bugs[12345]["assigned_to"], "[email protected]")
         self.assertEqual(
             bugs[12345]["summary"],
-            u"[DOGFOOD] Unable to Forward a message received as an Inline page or an attachment",
+            "[DOGFOOD] Unable to Forward a message received as an Inline page or an attachment",
         )
 
         self.assertEqual(bugs[12346]["id"], 12346)
-        self.assertEqual(bugs[12346]["resolution"], u"FIXED")
-        self.assertEqual(bugs[12346]["assigned_to"], u"[email protected]")
+        self.assertEqual(bugs[12346]["resolution"], "FIXED")
+        self.assertEqual(bugs[12346]["assigned_to"], "[email protected]")
         self.assertEqual(
-            bugs[12346]["summary"], u"nsOutputFileStream should buffer the output"
+            bugs[12346]["summary"], "nsOutputFileStream should buffer the output"
         )
 
     @responses.activate
@@ -75,20 +75,20 @@ def bughandler2(bug, data):
 
         for bugs in [bugs1, bugs2]:
             self.assertEqual(bugs[12345]["id"], 12345)
-            self.assertEqual(bugs[12345]["resolution"], u"FIXED")
+            self.assertEqual(bugs[12345]["resolution"], "FIXED")
             self.assertEqual(
-                bugs[12345]["assigned_to"], u"[email protected]"
+                bugs[12345]["assigned_to"], "[email protected]"
             )
             self.assertEqual(
                 bugs[12345]["summary"],
-                u"[DOGFOOD] Unable to Forward a message received as an Inline page or an attachment",
+                "[DOGFOOD] Unable to Forward a message received as an Inline page or an attachment",
             )
 
             self.assertEqual(bugs[12346]["id"], 12346)
-            self.assertEqual(bugs[12346]["resolution"], u"FIXED")
-            self.assertEqual(bugs[12346]["assigned_to"], u"[email protected]")
+            self.assertEqual(bugs[12346]["resolution"], "FIXED")
+            self.assertEqual(bugs[12346]["assigned_to"], "[email protected]")
             self.assertEqual(
-                bugs[12346]["summary"], u"nsOutputFileStream should buffer the output"
+                bugs[12346]["summary"], "nsOutputFileStream should buffer the output"
             )
 
     @responses.activate
@@ -112,20 +112,20 @@ def bughandler3(bug, data):
 
         for bugs in [bugs1, bugs2, bugs3]:
             self.assertEqual(bugs[12345]["id"], 12345)
-            self.assertEqual(bugs[12345]["resolution"], u"FIXED")
+            self.assertEqual(bugs[12345]["resolution"], "FIXED")
             self.assertEqual(
-                bugs[12345]["assigned_to"], u"[email protected]"
+                bugs[12345]["assigned_to"], "[email protected]"
             )
             self.assertEqual(
                 bugs[12345]["summary"],
-                u"[DOGFOOD] Unable to Forward a message received as an Inline page or an attachment",
+                "[DOGFOOD] Unable to Forward a message received as an Inline page or an attachment",
             )
 
             self.assertEqual(bugs[12346]["id"], 12346)
-            self.assertEqual(bugs[12346]["resolution"], u"FIXED")
-            self.assertEqual(bugs[12346]["assigned_to"], u"[email protected]")
+            self.assertEqual(bugs[12346]["resolution"], "FIXED")
+            self.assertEqual(bugs[12346]["assigned_to"], "[email protected]")
             self.assertEqual(
-                bugs[12346]["summary"], u"nsOutputFileStream should buffer the output"
+                bugs[12346]["summary"], "nsOutputFileStream should buffer the output"
             )
 
     @responses.activate
@@ -153,9 +153,9 @@ def bughandler2(bug, data):
         self.assertEqual(bugs1[12345]["id"], 12345)
         self.assertEqual(bugs1[12346]["id"], 12346)
         self.assertEqual(bugs2[12345]["id"], 12345)
-        self.assertEqual(bugs2[12345]["resolution"], u"FIXED")
+        self.assertEqual(bugs2[12345]["resolution"], "FIXED")
         self.assertEqual(bugs2[12346]["id"], 12346)
-        self.assertEqual(bugs2[12346]["resolution"], u"FIXED")
+        self.assertEqual(bugs2[12346]["resolution"], "FIXED")
 
     @responses.activate
     def test_queries(self):
@@ -173,18 +173,18 @@ def bughandler(data):
         bugzilla.Bugzilla(queries=queries, bughandler=bughandler).wait()
 
         self.assertEqual(bugs[12345]["id"], 12345)
-        self.assertEqual(bugs[12345]["resolution"], u"FIXED")
-        self.assertEqual(bugs[12345]["assigned_to"], u"[email protected]")
+        self.assertEqual(bugs[12345]["resolution"], "FIXED")
+        self.assertEqual(bugs[12345]["assigned_to"], "[email protected]")
         self.assertEqual(
             bugs[12345]["summary"],
-            u"[DOGFOOD] Unable to Forward a message received as an Inline page or an attachment",
+            "[DOGFOOD] Unable to Forward a message received as an Inline page or an attachment",
         )
 
         self.assertEqual(bugs[12346]["id"], 12346)
-        self.assertEqual(bugs[12346]["resolution"], u"FIXED")
-        self.assertEqual(bugs[12346]["assigned_to"], u"[email protected]")
+        self.assertEqual(bugs[12346]["resolution"], "FIXED")
+        self.assertEqual(bugs[12346]["assigned_to"], "[email protected]")
         self.assertEqual(
-            bugs[12346]["summary"], u"nsOutputFileStream should buffer the output"
+            bugs[12346]["summary"], "nsOutputFileStream should buffer the output"
         )
 
     @responses.activate
@@ -309,7 +309,7 @@ def historyhandler(bug, data):
 
         self.assertEqual(data["bug"]["id"], 12345)
         self.assertEqual(len(data["comment"]), 19)
-        self.assertTrue(data["comment"][0]["text"].startswith(u"Steps to reproduce"))
+        self.assertTrue(data["comment"][0]["text"].startswith("Steps to reproduce"))
         self.assertEqual(len(data["history"]["history"]), 24)
 
     @responses.activate
@@ -336,7 +336,7 @@ def historyhandler(bug, data):
 
         self.assertEqual(data["bug"]["id"], 12345)
         self.assertEqual(len(data["comment"]), 19)
-        self.assertTrue(data["comment"][0]["text"].startswith(u"Steps to reproduce"))
+        self.assertTrue(data["comment"][0]["text"].startswith("Steps to reproduce"))
         self.assertEqual(len(data["history"]["history"]), 24)
 
     @responses.activate
@@ -609,7 +609,7 @@ def attachmenthandler(bug, bugid, data):
 
         self.assertEqual(data["bug"]["id"], 12345)
         self.assertEqual(len(data["comment"]), 19)
-        self.assertTrue(data["comment"][0]["text"].startswith(u"Steps to reproduce"))
+        self.assertTrue(data["comment"][0]["text"].startswith("Steps to reproduce"))
         self.assertEqual(len(data["history"]["history"]), 24)
         self.assertEqual(len(data["attachment"]), 1)
         self.assertEqual(data["attachment"][0]["description"], "Some patch.")
@@ -645,7 +645,7 @@ def attachmenthandler(bug, bugid, data):
 
         self.assertEqual(data["bug"]["id"], 12345)
         self.assertEqual(len(data["comment"]), 19)
-        self.assertTrue(data["comment"][0]["text"].startswith(u"Steps to reproduce"))
+        self.assertTrue(data["comment"][0]["text"].startswith("Steps to reproduce"))
         self.assertEqual(len(data["history"]["history"]), 24)
         self.assertEqual(len(data["attachment"]), 1)
         self.assertEqual(data["attachment"][0]["description"], "Some patch.")

tests/test_bzinfo.py

@@ -14,7 +14,7 @@ def test_bzinfo(self):
         self.assertIn("12345", info)
         info = info["12345"]
         self.assertTrue(info["authorized"])
-        self.assertEqual(info["owner"], u"[email protected]")
+        self.assertEqual(info["owner"], "[email protected]")
         # self.assertIn(u'[email protected]', info['commenters'])
         self.assertEqual(info["component"], "Backend")
         self.assertEqual(info["product"], "MailNews Core")