lines begin with 1 #523
Merged
lines begin with 1 #523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marco-c
reviewed
May 15, 2020
frontend/src/index.js
Outdated
| @@ -159,6 +159,7 @@ async function showFile(source, file, revision, selectedLine) { | |||
| language, | |||
| lines: source.map((line, nb) => { | |||
| const coverage = file.coverage[nb]; | |||
| nb = nb + 1; | |||
There was a problem hiding this comment.
Looks good, but please:
- move it after line 185;
- add a comment before it to explain why we need to do it.
There was a problem hiding this comment.
Made the changes. Please let me know if anything else is required. :)
marco-c
approved these changes
May 18, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #316 by incrementing the div ids (ie l0 becomes l1, l1 becomes l2....) of the line number fields by 1.