-
Notifications
You must be signed in to change notification settings - Fork 89
bot: replaced retry function with Tenacity #366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… Removed import of retry utility.
…on. Removed retry runction from utils.py
Merge with update from master with Mozilla.
There are some linting failures (I suggest using pre-commit for that), and some test failures (you can run tests by doing |
@seb-sojka do you still want to work on this? |
…d utils.py and taskcluster.py because pre-commit run
…try of perform_download
Hello, |
Probably tenacity is not using time.sleep. You can change the test to stop mocking it, and instead count the number of times the responses URL is hit (see https://github.com/getsentry/responses, something like |
…s.py. Updated test_taskcluster.py to check on number of times a function is called
The error with linit and taskcluster_yml. I am unsure what the solution for this. I do not have this error locally when I run the pre-commit. |
Looks good, just one last thing to fix! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
If you want, here are some similar issues in this and other repos: |
Remove retry function and related RunException from utils.py for bot and replaces it with Tenacity retry in taskcluster.py and uploader.py
Fixes #110