Skip to content

Frontend lint #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 6, 2019
Merged

Frontend lint #146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5c3f8d2
frontend: Setup eslint with mozilla rules
Sep 6, 2019
95aaed7
frontend: eslint auto fixes
Sep 6, 2019
56f634f
frontend: fix eqeqeq rule
Sep 6, 2019
59cbe3c
frontend: fix camelcase rule
Sep 6, 2019
d897995
frontend: Manual eslint fixes
Sep 6, 2019
a697fc3
Fixes after rebase
Sep 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions frontend/.eslintrc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
env:
browser: true
es6: true
plugins:
- prettier
- mozilla
extends:
- standard
- prettier
- plugin:mozilla/recommended
globals:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default settings from eslint.
I trust those real JS dev to know what they do 😏

Atomics: readonly
SharedArrayBuffer: readonly
parserOptions:
ecmaVersion: 2018
sourceType: module
rules:
max-len: off
prettier/prettier: "error"
11 changes: 11 additions & 0 deletions frontend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,20 @@
"babel-polyfill": "^6.26.0",
"clean-webpack-plugin": "^3.0.0",
"css-loader": "^3.0.0",
"eslint": "^6.2.2",
"eslint-config-prettier": "^6.2.0",
"eslint-config-standard": "^14.1.0",
"eslint-loader": "^3.0.0",
"eslint-plugin-fetch-options": "0.0.5",
"eslint-plugin-html": "^6.0.0",
"eslint-plugin-mozilla": "^2.1.0",
"eslint-plugin-no-unsanitized": "^3.0.2",
"eslint-plugin-prettier": "^3.1.0",
"html-webpack-plugin": "^3.2.0",
"mini-css-extract-plugin": "^0.8.0",
"optimize-css-assets-webpack-plugin": "^5.0.3",
"prettier": "1.18.2",
"standard": "^14.1.0",
"terser-webpack-plugin": "^1.3.0",
"webpack": "^4.35.3",
"webpack-cli": "^3.3.6",
Expand Down
Loading