more types

Author: willdurand

src/api/index.tsx

@@ -16,6 +16,8 @@ type CallApiParams = {
   apiState: ApiState;
 };
 
+type CallApiResponse = object | { error: Error };
+
 type Headers = {
   [name: string]: string;
 };
@@ -25,7 +27,7 @@ export const callApi = async ({
   endpoint,
   method = HttpMethod.GET,
   version = 'v4',
-}: CallApiParams): Promise<object | { error: Error }> => {
+}: CallApiParams): Promise<CallApiResponse> => {
   if (!endpoint.startsWith('/')) {
     // eslint-disable-next-line no-param-reassign
     endpoint = `/${endpoint}`;
@@ -63,7 +65,9 @@ export const callApi = async ({
   }
 };
 
-export const logOutFromServer = async (apiState: ApiState) => {
+export const logOutFromServer = async (
+  apiState: ApiState,
+): Promise<CallApiResponse> => {
   return callApi({
     apiState,
     endpoint: 'accounts/session',

src/components/App/index.test.tsx

@@ -1,5 +1,5 @@
 import React from 'react';
-import { shallow } from 'enzyme';
+import { ShallowWrapper, shallow } from 'enzyme';
 import { Store } from 'redux';
 
 import styles from './styles.module.scss';
@@ -17,7 +17,7 @@ describe(__filename, () => {
   const render = ({
     store = configureStore(),
     authToken = 'some-token',
-  }: RenderParams = {}) => {
+  }: RenderParams = {}): ShallowWrapper => {
     // TODO: Use shallowUntilTarget()
     // https://github.com/mozilla/addons-code-manager/issues/15
     const root = shallow(<App authToken={authToken} />, {

src/components/App/index.tsx

@@ -41,15 +41,15 @@ class AppBase extends React.Component<Props, State> {
     };
   }
 
-  componentDidMount() {
+  componentDidMount(): void {
     const { authToken, dispatch } = this.props;
 
     if (authToken) {
       dispatch(apiActions.setAuthToken({ authToken }));
     }
   }
 
-  async componentDidUpdate(prevProps: Props) {
+  async componentDidUpdate(prevProps: Props): Promise<void> {
     const { apiState } = this.props;
 
     if (
@@ -68,7 +68,7 @@ class AppBase extends React.Component<Props, State> {
     }
   }
 
-  logOut = async () => {
+  logOut = async (): Promise<void> => {
     const { apiState } = this.props;
 
     this.setState({ isLoggingOut: true });
@@ -78,13 +78,15 @@ class AppBase extends React.Component<Props, State> {
     this.setState({ profile: null, isLoggingOut: false });
   };
 
-  handleToggleClick = (event: React.SyntheticEvent<HTMLButtonElement>) => {
+  handleToggleClick = (
+    event: React.SyntheticEvent<HTMLButtonElement>,
+  ): void => {
     const { dispatch } = this.props;
     event.preventDefault();
     dispatch(exampleActions.toggle());
   };
 
-  render() {
+  render(): React.ReactNode {
     const { toggledOn } = this.props;
     const { profile, isLoggingOut } = this.state;
 

src/components/LoginButton/index.tsx

@@ -3,13 +3,13 @@ import * as React from 'react';
 import styles from './styles.module.scss';
 
 export class LoginButtonBase extends React.Component {
-  getFxaURL() {
+  getFxaURL(): string {
     const fxaConfig = process.env.REACT_APP_FXA_CONFIG;
 
     return `/api/v4/accounts/login/start/?config=${fxaConfig}&to=/`;
   }
 
-  render() {
+  render(): React.ReactNode {
     return (
       <a href={this.getFxaURL()} className={styles.link}>
         Log in