Issue with casing of headers

[eric-swann-q2]

I noticed that one of the tests was failing and that one of my changes had been reverted, which was causing the test failure. It's this line:

const segment = new AWSXray.Segment(name, header.Root, header.Parent);

Following what was done in the express middleware, I had changed it to:

const segment = new AWSXray.Segment(name, header.root, header.parent);

The test stub sets up the headers expecting them to be lowercase.

I know that node typically lowercases headers:
nodejs/node-v0.x-archive#1954

Was this causing an issue for you in your testing with the segment not getting set properly?

Would it make sense to do the following in case they do come in lowercased?

const segment = new AWSXray.Segment(name, header.Root || header.root, 
header.Parent || header.parent);

[moonthug]

This is a weird one. In my testing, this was causing an issue, having got the result of the header in a down stream service resembling the following. However the express example seems to suggest otherwise.

{
  "Root": "1-5ec40b48-a592b45a8149ed2c393487c4",
  "Parent": "8dc7444e7b4a7b9c",
  "Sampled": "1"
}

I'm happy to go with your suggestion. I'll get it updated and published on 3.0.2.

🍻

[moonthug]

Seems to be related to how the xray-patched version of http puts values into the Xray headers.

https://github.com/aws/aws-xray-sdk-node/blob/master/packages/core/lib/patchers/http_p.js#L124

I'll check if theres a ticket with the express version.

[eric-swann-q2]

OK cool