Skip to content

DRIVERS-2976 Removed deprecated GridFS fields from tests: md5, contentType, aliases #1683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Oct 28, 2024

Fix DRIVERS-2976

Fields md5, contentType and contentType were deprecated.

  • Remove the fields from the fixtures, so we test reading fields that doesn't contain this fields
  • Remove the test setting contentType, as this deprecated feature doesn't need to be implemented

From the spec:

If not provided the driver MUST omit the aliases field from the files collection document.

Please complete the following before merging:

  • Update changelog.
  • Make sure there are generated JSON files from the YAML test files.
  • Test changes in at least one language driver. (on PHPLIB)
  • Test these changes against all server versions and topologies (including standalone, replica set, sharded clusters, and serverless).

@GromNaN GromNaN requested a review from a team as a code owner October 28, 2024 11:49
@GromNaN GromNaN requested review from dariakp and alcaeus and removed request for a team and dariakp October 28, 2024 11:49
@GromNaN GromNaN merged commit 12be2df into mongodb:master Oct 28, 2024
4 checks passed
@GromNaN GromNaN deleted the DRIVERS-2976 branch October 28, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants