DRIVERS-2327: limit prose test to server versions 6.0+ #1304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilshweky
requested review from
isabelatkinson
and removed request for
a team
neilshweky
commented
Sep 9, 2022
neilshweky
changed the title
ShaneHarvey
approved these changes
Sep 12, 2022
isabelatkinson
approved these changes
Sep 13, 2022
kmahar
pushed a commit
that referenced
this pull request
Sep 15, 2022
* DRIVERS-2327: limit prose test to server versions 6.0+
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is doubt as to whether we should limit this prose test to 4.4+ or 6.1+. This test will work on versions 4.4+, but it doesn't become relevant until 6.1+. For now, I have left it as 4.4+, but I am open to changing it. See the discussion here.
EDIT: Consensus seems to be that this change will be backported to 6.0, so I will leave this test as 6.0+.