-
Notifications
You must be signed in to change notification settings - Fork 1.8k
refactor(NODE-3717): test reorg part 4 #3086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
durran
reviewed
Dec 17, 2021
Test numbers on evg patch vs main look good. Just the one comment for clarification. |
durran
approved these changes
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NODE-3717
What is changing?
Separating spec tests from integration tests and moving the related tests from functional into integration test directory.
This PR covers almost all files that actually reference existing spec files.
Note: I noticed that the connection string spec tests also include auth spec tests, but I think we can clean that up more when we do the full spec audit.
Is there new documentation needed for these changes?
N/A
What is the motivation for this change?
Consistent test organization
Double check the following
npm run check:lint
script<type>(NODE-xxxx)<!>: <description>