Skip to content

refactor(NODE-3717): test reorg part 4 #3086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Dec 17, 2021
Merged

Conversation

dariakp
Copy link
Contributor

@dariakp dariakp commented Dec 16, 2021

Description

NODE-3717

What is changing?

Separating spec tests from integration tests and moving the related tests from functional into integration test directory.

This PR covers almost all files that actually reference existing spec files.

Note: I noticed that the connection string spec tests also include auth spec tests, but I think we can clean that up more when we do the full spec audit.

Is there new documentation needed for these changes?

N/A

What is the motivation for this change?

Consistent test organization

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • [N/A] Changes are covered by tests
  • [N/A] New TODOs have a related JIRA ticket

@dariakp dariakp marked this pull request as ready for review December 16, 2021 23:53
@dariakp dariakp added the Team Review Needs review from team label Dec 16, 2021
@durran
Copy link
Member

durran commented Dec 17, 2021

Test numbers on evg patch vs main look good. Just the one comment for clarification.

@durran durran merged commit 55d1c5f into main Dec 17, 2021
@durran durran deleted the NODE-3717/reorganize-tests-pt4 branch December 17, 2021 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants