Skip to content

test(NODE-3713): skip/fix failing evergreen tests #3069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 17, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .evergreen/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ functions:
type: test
params:
working_dir: src
timeout_secs: 60
timeout_secs: 300
script: |
${PREPARE_SHELL}

Expand Down Expand Up @@ -186,7 +186,7 @@ functions:
type: test
params:
working_dir: src
timeout_secs: 60
timeout_secs: 300
script: |
${PREPARE_SHELL}

Expand Down
4 changes: 2 additions & 2 deletions .evergreen/config.yml.in
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ functions:
type: test
params:
working_dir: "src"
timeout_secs: 60
timeout_secs: 300
script: |
${PREPARE_SHELL}

Expand Down Expand Up @@ -210,7 +210,7 @@ functions:
type: test
params:
working_dir: src
timeout_secs: 60
timeout_secs: 300
script: |
${PREPARE_SHELL}

Expand Down
4 changes: 3 additions & 1 deletion test/functional/connections_stepdown.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@ function expectPoolWasNotCleared(initialCount) {
return count => expect(count).to.equal(initialCount);
}

describe('Connections survive primary step down', function () {
// TODO: NODE-3819: Unskip flaky MacOS tests.
const maybeDescribe = process.platform === 'darwin' ? describe.skip : describe;
maybeDescribe('Connections survive primary step down', function () {
let client;
let checkClient;
let db;
Expand Down
4 changes: 3 additions & 1 deletion test/functional/cursorstream.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,9 @@ describe('Cursor Streams', function () {
}
});

it('should stream documents across getMore command and count correctly', {
// TODO: NODE-3819: Unskip flaky MacOS tests.
const maybeIt = process.platform === 'darwin' ? it.skip : it;
maybeIt('should stream documents across getMore command and count correctly', {
metadata: {
requires: { topology: ['single', 'replicaset', 'sharded', 'ssl', 'heap', 'wiredtiger'] }
},
Expand Down
4 changes: 3 additions & 1 deletion test/functional/examples/change_streams.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@
const setupDatabase = require('../shared').setupDatabase;
const expect = require('chai').expect;

describe('examples(change-stream):', function () {
// TODO: NODE-3819: Unskip flaky MacOS/Windows tests.
const maybeDescribe = process.platform !== 'linux' ? describe.skip : describe;
maybeDescribe('examples(change-stream):', function () {
let client;
let db;

Expand Down
3 changes: 2 additions & 1 deletion test/functional/find.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -1655,7 +1655,8 @@ describe('Find', function () {
}
});

it('shouldCorrectlyIterateOverCollection', {
// TODO: NODE-3819: Unskip flaky tests.
it.skip('shouldCorrectlyIterateOverCollection', {
metadata: {
requires: { topology: ['single', 'replicaset', 'sharded', 'ssl', 'heap', 'wiredtiger'] }
},
Expand Down
3 changes: 2 additions & 1 deletion test/functional/unit-sdam/monitoring.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ describe('monitoring', function () {
return mock.createServer().then(server => (mockServer = server));
});

it('should record roundTripTime', function (done) {
// TODO: NODE-3819: Unskip flaky tests.
it.skip('should record roundTripTime', function (done) {
mockServer.setMessageHandler(request => {
const doc = request.document;
if (isHello(doc)) {
Expand Down
4 changes: 3 additions & 1 deletion test/integration/change-streams/change_stream.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -509,7 +509,9 @@ describe('Change Streams', function () {
}
});

it('should cache the change stream resume token using promises', {
// TODO: NODE-3819: Unskip flaky MacOS tests.
const maybeIt = process.platform === 'darwin' ? it.skip : it;
maybeIt('should cache the change stream resume token using promises', {
metadata: { requires: { topology: 'replicaset', mongodb: '>=3.6' } },
test: function () {
const configuration = this.configuration;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@ describe('Change Streams Spec - Unified', function () {
runUnifiedSuite(loadSpecTests(path.join('change-streams', 'unified')));
});

describe('Change Stream Spec - v1', function () {
// TODO: NODE-3819: Unskip flaky MacOS tests.
const maybeDescribe = process.platform === 'darwin' ? describe.skip : describe;
maybeDescribe('Change Stream Spec - v1', function () {
let globalClient;
let ctx;
let events;
Expand Down
3 changes: 2 additions & 1 deletion test/integration/read-write-concern/write_concern.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,8 @@ describe('Write Concern', function () {

after(() => mock.cleanup());

it('should pipe writeConcern from client down to API call', function () {
// TODO: NODE-3816
it.skip('should pipe writeConcern from client down to API call', function () {
server.setMessageHandler(request => {
if (request.document && request.document[LEGACY_HELLO_COMMAND]) {
return request.reply(mock.HELLO);
Expand Down
4 changes: 2 additions & 2 deletions test/manual/kerberos.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ describe('Kerberos', function () {
client.connect(function (err) {
expect(err).to.exist;
expect(err.message).to.match(
/(Error from KDC: LOOKING_UP_SERVER)|(not found in Kerberos database)/
/(Error from KDC: LOOKING_UP_SERVER)|(not found in Kerberos database)|(UNKNOWN_SERVER)/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is interesting - just curious how/when/why this manifested?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It started happening last week and only on MacOS. I'm trying to pin down the root cause at the moment but Kerberos knowledge is obviously not one of my strengths.

);
done();
});
Expand All @@ -85,7 +85,7 @@ describe('Kerberos', function () {
client.connect(function (err) {
expect(err).to.exist;
expect(err.message).to.match(
/(Error from KDC: LOOKING_UP_SERVER)|(not found in Kerberos database)/
/(Error from KDC: LOOKING_UP_SERVER)|(not found in Kerberos database)|(UNKNOWN_SERVER)/
);
done();
});
Expand Down