docs(NODE-3650): Note that boolean options must now be specified as booleans in upgrade guide #3017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ooleans in upgrade guide
dariakp
requested changes
Oct 26, 2021
dariakp
added
the
Primary Review
Co-authored-by: Daria Pardue <[email protected]>
durran
approved these changes
Oct 26, 2021
dariakp
pushed a commit
that referenced
this pull request
Nov 2, 2021
…ooleans in upgrade guide (#3017)
ljhaywar
pushed a commit
that referenced
this pull request
Nov 9, 2021
…ooleans in upgrade guide (#3017)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Driver 3.x would accept values such as
0and1in place of booleans. We no longer accept them as of 4.0. This PR notes the change in the upgrade guide.What is changing?
Added a section to the upgrade guide.
Is there new documentation needed for these changes?
This is documentation 🙂
What is the motivation for this change?
A user was confused by this behavior and posted on the community forums about it.
Double check the following
npm run check:lintscript (to be honest I didn't do this because I don't have a local dev environment set up, but I doubt this file gets linted 🙂)<type>(NODE-xxxx)<!>: <description>