Skip to content

feat(NODE-3469,NODE-3615,NODE-3507): update min and max wire versions #3014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Nov 2, 2021
Merged

feat(NODE-3469,NODE-3615,NODE-3507): update min and max wire versions #3014

Show file tree
Hide file tree
Changes from 18 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
169ef69
feat(NODE-3469): update min wire version
durran Oct 24, 2021
2a6528b
fix: update evergreen to supported mongodb version
durran Oct 24, 2021
552cfaf
feat(NODE-3615): bump max wire version to 14
durran Oct 26, 2021
7c61183
test: fix remaining 36 hello responses
durran Oct 26, 2021
70e3b79
Revert "test: fix remaining 36 hello responses"
durran Oct 26, 2021
bf14621
test: add more session leak debug
durran Oct 27, 2021
3d10f88
test: list sessions getting aquired and released
durran Oct 27, 2021
c90a3e8
test: only output session id
durran Oct 27, 2021
e998ae9
test: log error output on bypass validation
durran Oct 27, 2021
ddaad26
test: fix scram iteration tests
durran Oct 28, 2021
676e72a
test: fix sessions unit tests
durran Oct 28, 2021
e011dde
test: fix bypass validation tests
durran Oct 28, 2021
8882175
test: refactor list collections unit test
durran Oct 28, 2021
13c3b06
test: fix command write concern test
durran Oct 28, 2021
edb9953
test: fix collation tests
durran Oct 28, 2021
a9c4b3a
test: fix remaining collation tests
durran Oct 28, 2021
ddd9d5d
test: fix max staleness, rs, views tests
durran Oct 28, 2021
5d66ef7
test(NODE-3507): sync sdam spec tests
durran Oct 28, 2021
08eabf8
docs: update generateCommand docs
durran Nov 1, 2021
5741f64
test: replace DEFAULT_ISMASTER_36 with HELLO
durran Nov 1, 2021
e8a82fa
test: replace DEFAULT_ISMASTER with LEGACY_HELLO
durran Nov 1, 2021
fdd395c
test: fix linter errors
durran Nov 1, 2021
c909b85
test: remove remaining legacy hello in tests
durran Nov 2, 2021
4fab065
test: remove unused mongos fixture
durran Nov 2, 2021
5252555
remove stray console log
dariakp Nov 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
168 changes: 0 additions & 168 deletions .evergreen/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -852,138 +852,6 @@ tasks:
VERSION: '3.6'
TOPOLOGY: sharded_cluster
- func: run tests
- name: test-3.4-server
tags:
- '3.4'
- server
commands:
- func: install dependencies
- func: bootstrap mongo-orchestration
vars:
VERSION: '3.4'
TOPOLOGY: server
- func: run tests
- name: test-3.4-replica_set
tags:
- '3.4'
- replica_set
commands:
- func: install dependencies
- func: bootstrap mongo-orchestration
vars:
VERSION: '3.4'
TOPOLOGY: replica_set
- func: run tests
- name: test-3.4-sharded_cluster
tags:
- '3.4'
- sharded_cluster
commands:
- func: install dependencies
- func: bootstrap mongo-orchestration
vars:
VERSION: '3.4'
TOPOLOGY: sharded_cluster
- func: run tests
- name: test-3.2-server
tags:
- '3.2'
- server
commands:
- func: install dependencies
- func: bootstrap mongo-orchestration
vars:
VERSION: '3.2'
TOPOLOGY: server
- func: run tests
- name: test-3.2-replica_set
tags:
- '3.2'
- replica_set
commands:
- func: install dependencies
- func: bootstrap mongo-orchestration
vars:
VERSION: '3.2'
TOPOLOGY: replica_set
- func: run tests
- name: test-3.2-sharded_cluster
tags:
- '3.2'
- sharded_cluster
commands:
- func: install dependencies
- func: bootstrap mongo-orchestration
vars:
VERSION: '3.2'
TOPOLOGY: sharded_cluster
- func: run tests
- name: test-3.0-server
tags:
- '3.0'
- server
commands:
- func: install dependencies
- func: bootstrap mongo-orchestration
vars:
VERSION: '3.0'
TOPOLOGY: server
- func: run tests
- name: test-3.0-replica_set
tags:
- '3.0'
- replica_set
commands:
- func: install dependencies
- func: bootstrap mongo-orchestration
vars:
VERSION: '3.0'
TOPOLOGY: replica_set
- func: run tests
- name: test-3.0-sharded_cluster
tags:
- '3.0'
- sharded_cluster
commands:
- func: install dependencies
- func: bootstrap mongo-orchestration
vars:
VERSION: '3.0'
TOPOLOGY: sharded_cluster
- func: run tests
- name: test-2.6-server
tags:
- '2.6'
- server
commands:
- func: install dependencies
- func: bootstrap mongo-orchestration
vars:
VERSION: '2.6'
TOPOLOGY: server
- func: run tests
- name: test-2.6-replica_set
tags:
- '2.6'
- replica_set
commands:
- func: install dependencies
- func: bootstrap mongo-orchestration
vars:
VERSION: '2.6'
TOPOLOGY: replica_set
- func: run tests
- name: test-2.6-sharded_cluster
tags:
- '2.6'
- sharded_cluster
commands:
- func: install dependencies
- func: bootstrap mongo-orchestration
vars:
VERSION: '2.6'
TOPOLOGY: sharded_cluster
- func: run tests
- name: test-latest-server-v1-api
tags:
- latest
Expand Down Expand Up @@ -1810,18 +1678,6 @@ buildvariants:
- test-3.6-server
- test-3.6-replica_set
- test-3.6-sharded_cluster
- test-3.4-server
- test-3.4-replica_set
- test-3.4-sharded_cluster
- test-3.2-server
- test-3.2-replica_set
- test-3.2-sharded_cluster
- test-3.0-server
- test-3.0-replica_set
- test-3.0-sharded_cluster
- test-2.6-server
- test-2.6-replica_set
- test-2.6-sharded_cluster
- test-latest-server-v1-api
- test-atlas-connectivity
- test-atlas-data-lake
Expand Down Expand Up @@ -1891,18 +1747,6 @@ buildvariants:
- test-3.6-server
- test-3.6-replica_set
- test-3.6-sharded_cluster
- test-3.4-server
- test-3.4-replica_set
- test-3.4-sharded_cluster
- test-3.2-server
- test-3.2-replica_set
- test-3.2-sharded_cluster
- test-3.0-server
- test-3.0-replica_set
- test-3.0-sharded_cluster
- test-2.6-server
- test-2.6-replica_set
- test-2.6-sharded_cluster
- test-latest-server-v1-api
- test-atlas-connectivity
- test-atlas-data-lake
Expand Down Expand Up @@ -1973,18 +1817,6 @@ buildvariants:
- test-3.6-server
- test-3.6-replica_set
- test-3.6-sharded_cluster
- test-3.4-server
- test-3.4-replica_set
- test-3.4-sharded_cluster
- test-3.2-server
- test-3.2-replica_set
- test-3.2-sharded_cluster
- test-3.0-server
- test-3.0-replica_set
- test-3.0-sharded_cluster
- test-2.6-server
- test-2.6-replica_set
- test-2.6-sharded_cluster
- test-latest-server-v1-api
- test-atlas-data-lake
- test-ocsp-valid-cert-server-staples
Expand Down
6 changes: 3 additions & 3 deletions .evergreen/generate_evergreen_tasks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ const fs = require('fs');
const yaml = require('js-yaml');

const LATEST_EFFECTIVE_VERSION = '5.0';
const MONGODB_VERSIONS = ['latest', '5.0', '4.4', '4.2', '4.0', '3.6', '3.4', '3.2', '3.0', '2.6'];
const MONGODB_VERSIONS = ['latest', '5.0', '4.4', '4.2', '4.0', '3.6'];
const NODE_VERSIONS = ['erbium', 'fermium'];
NODE_VERSIONS.sort();
const LOWEST_LTS = NODE_VERSIONS[0];
Expand Down Expand Up @@ -34,7 +34,7 @@ const OPERATING_SYSTEMS = [
clientEncryption: false // TODO(NODE-3401): Unskip when Windows no longer fails to launch mongocryptd occasionally
}
].map(osConfig => ({
mongoVersion: '>=2.6',
mongoVersion: '>=3.6',
nodeVersion: LOWEST_LTS,
auth: false, // TODO test auth?
clientEncryption: true,
Expand Down Expand Up @@ -484,7 +484,7 @@ OPERATING_SYSTEMS.forEach(
name: osName,
display_name: osDisplayName,
run_on,
mongoVersion = '>=2.6',
mongoVersion = '>=3.6',
nodeVersions = NODE_VERSIONS,
clientEncryption,
msvsVersion
Expand Down
8 changes: 4 additions & 4 deletions src/cmap/wire_protocol/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
export const MIN_SUPPORTED_SERVER_VERSION = '2.6';
export const MAX_SUPPORTED_SERVER_VERSION = '5.0';
export const MIN_SUPPORTED_WIRE_VERSION = 2;
export const MAX_SUPPORTED_WIRE_VERSION = 13;
export const MIN_SUPPORTED_SERVER_VERSION = '3.6';
export const MAX_SUPPORTED_SERVER_VERSION = '5.1';
export const MIN_SUPPORTED_WIRE_VERSION = 6;
export const MAX_SUPPORTED_WIRE_VERSION = 14;
export const OP_REPLY = 1;
export const OP_UPDATE = 2001;
export const OP_INSERT = 2002;
Expand Down
9 changes: 6 additions & 3 deletions src/operations/list_collections.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,14 +90,17 @@ export class ListCollectionsOperation extends CommandOperation<string[]> {
return;
}

const command = {
return super.executeCommand(server, session, this.generateCommand(), callback);
}

/** @internal */
generateCommand(): Document {
return {
listCollections: 1,
filter: this.filter,
cursor: this.batchSize ? { batchSize: this.batchSize } : {},
nameOnly: this.nameOnly
};

return super.executeCommand(server, session, command, callback);
}
}

Expand Down
Loading