-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat(NODE-5825): add minRoundTripTime to ServerDescription and change roundTripTime to a moving average
#4059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
W-A-James
commented
Mar 29, 2024
87e84e7 to
63d7b52
Compare
W-A-James
commented
Mar 29, 2024
W-A-James
commented
Apr 1, 2024
W-A-James
commented
Apr 1, 2024
W-A-James
commented
Apr 1, 2024
nbbeeken
suggested changes
Apr 1, 2024
This was referenced Sep 7, 2024
This was referenced Sep 24, 2024
This was referenced Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Monitor changes
rttSamplesMSinternal fieldroundTripTimegetterlatestRTTgetteraddRttSamplemethodclearRttSamplesmethod and call inresetMonitorStateRTTSamplerclass to implement spec-defined minimum and average RTT calculationsRTTPingerchangesmonitorfield to reference parentMonitorlatestRTTfield, initialized to the the monitor'slatestRTTvaluemeasureAndRescheduleto use fewer closures and clarify control flowServerDescriptionchangesminRoundTripTimefieldroundTripTimefield#####Connectionchanges- Addmonitorfield toconnectionto facilitate plumbing of minRoundTrip time to connection layerIs there new documentation needed for these changes?
What is the motivation for this change?
Release Highlight
ServerDescriptionRound Trip Time (RTT) measurement changesServerDescription.roundTripTimeis now a moving averagePreviously,
ServerDescription.roundTripTimewas calculated as a weighted average of the most recently observed heartbeat duration and the previous duration. This update changes this behaviour to averageServerDescription.roundTripTimeover the last 10 observed heartbeats. This should reduce the likelihood that the selected server changes as a result of momentary spikes in server latency.Added
minRoundTripTimetoServerDescriptionA new
minRoundTripTimeproperty is now available on theServerDescriptionclass which gives the minimum rtt over the last 10 heartbeats. Note that this value will be reported as 0 when fewer than 2 samples have been obvserved.Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript