tests

Author: baileympearson

src/cmap/connection.ts

@@ -237,6 +237,8 @@ export class Connection extends TypedEventEmitter<ConnectionEvents> {
       .on('error', this.onError.bind(this));
     this.socket.on('close', this.onClose.bind(this));
     this.socket.on('timeout', this.onTimeout.bind(this));
+
+    this.messageStream.pause();
   }
 
   public get hello() {
@@ -427,11 +429,8 @@ export class Connection extends TypedEventEmitter<ConnectionEvents> {
   ): AsyncGenerator<MongoDBResponse> {
     this.throwIfAborted();
 
-    if (typeof options.socketTimeoutMS === 'number') {
-      this.socket.setTimeout(options.socketTimeoutMS);
-    } else if (this.socketTimeoutMS !== 0) {
-      this.socket.setTimeout(this.socketTimeoutMS);
-    }
+    const socketTimeoutMS = options.socketTimeoutMS ?? this.socketTimeoutMS ?? 0;
+    this.socket.setTimeout(socketTimeoutMS);
 
     try {
       await this.writeCommand(message, {
@@ -455,11 +454,7 @@ export class Connection extends TypedEventEmitter<ConnectionEvents> {
         yield document;
         this.throwIfAborted();
 
-        if (typeof options.socketTimeoutMS === 'number') {
-          this.socket.setTimeout(options.socketTimeoutMS);
-        } else if (this.socketTimeoutMS !== 0) {
-          this.socket.setTimeout(this.socketTimeoutMS);
-        }
+        this.socket.setTimeout(socketTimeoutMS);
       }
     } finally {
       this.socket.setTimeout(0);

test/unit/cmap/connection.test.ts

@@ -1,4 +1,4 @@
-import { Duplex } from 'node:stream';
+import { Socket } from 'node:net';
 
 import { expect } from 'chai';
 import * as sinon from 'sinon';
@@ -147,7 +147,7 @@ describe('new Connection()', function () {
     expect(error).to.have.property(beforeHandshakeSymbol, true);
   });
 
-  class MockSocket extends Duplex {
+  class MockSocket extends Socket {
     override write(_data: string | Buffer) {
       return false;
     }
@@ -168,7 +168,7 @@ describe('new Connection()', function () {
     }
   }
 
-  describe('NODE-6370: regression test', function () {
+  describe.only('NODE-6370: regression test', function () {
     let socket: MockSocket;
     let connection: Connection;
 
@@ -314,7 +314,6 @@ describe('new Connection()', function () {
 
         describe('when the data comes in multiple chunks', function () {
           it('does not hang', async function () {
-            // MockSocket.DEBUG = true;
             const result$ = connection.command(
               MongoDBCollectionNamespace.fromString('foo.bar'),
               { ping: 1 },