MOTOR-1212 Update QA Checks to Match PyMongo (#234)

* clean up config

* cleanup

* clean up

* fix pytest config

* clean up typing

Author: blink1073

.github/workflows/test-python.yml

@@ -102,16 +102,12 @@ jobs:
   typing:
     name: Typing Tests
     runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        python-version: ['3.7', '3.12']
-      fail-fast: false
     steps:
       - uses: actions/checkout@v2
-      - name: Set up Python ${{ matrix.python-version }}
+      - name: Set up Python
         uses: actions/setup-python@v4
         with:
-          python-version: ${{ matrix.python-version }}
+          python-version: "3.10"
           cache: 'pip'
           cache-dependency-path: 'pyproject.toml'
           allow-prereleases: true

MANIFEST.in

@@ -1,9 +1,7 @@
 include README.rst
 include LICENSE
 include tox.ini
-include pytest.ini
 include pyproject.toml
-include mypy.ini
 include doc/Makefile
 include doc/examples/tornado_change_stream_templates/index.html
 recursive-include doc *.rst

motor/__init__.py

@@ -19,7 +19,7 @@
 
 
 try:
-    import tornado  # type:ignore[import]
+    import tornado
 except ImportError:
     tornado = None
 else:

motor/_version.py

@@ -19,7 +19,7 @@
 def get_version_string() -> str:
     if isinstance(version_tuple[-1], str):
         return ".".join(map(str, version_tuple[:-1])) + version_tuple[-1]
-    return ".".join(map(str, version_tuple))
+    return ".".join(map(str, version_tuple))  # type:ignore[unreachable]
 
 
 version = get_version_string()

motor/metaprogramming.py

@@ -15,7 +15,7 @@
 """Dynamic class-creation for Motor."""
 import functools
 import inspect
-from typing import Any, Callable, Dict
+from typing import Any, Callable, Dict, TypeVar
 
 _class_cache: Dict[Any, Any] = {}
 
@@ -264,7 +264,10 @@ def return_clone(self, *args, **kwargs):
         return return_clone
 
 
-def create_class_with_framework(cls, framework, module_name):
+T = TypeVar("T")
+
+
+def create_class_with_framework(cls: T, framework: Any, module_name: str) -> T:
     motor_class_name = framework.CLASS_PREFIX + cls.__motor_class_name__
     cache_key = (cls, motor_class_name, framework)
     cached_class = _class_cache.get(cache_key)

motor/motor_asyncio.py

@@ -13,11 +13,9 @@
 # limitations under the License.
 
 """Asyncio support for Motor, an asynchronous driver for MongoDB."""
-from typing import TypeVar
-
 from . import core, motor_gridfs
 from .frameworks import asyncio as asyncio_framework
-from .metaprogramming import create_class_with_framework
+from .metaprogramming import T, create_class_with_framework
 
 __all__ = [
     "AsyncIOMotorClient",
@@ -34,8 +32,6 @@
     "AsyncIOMotorClientEncryption",
 ]
 
-T = TypeVar("T")
-
 
 def create_asyncio_class(cls: T) -> T:
     return create_class_with_framework(cls, asyncio_framework, "motor.motor_asyncio")

motor/motor_tornado.py

@@ -13,11 +13,10 @@
 # limitations under the License.
 
 """Tornado support for Motor, an asynchronous driver for MongoDB."""
-from typing import TypeVar
 
 from . import core, motor_gridfs
 from .frameworks import tornado as tornado_framework
-from .metaprogramming import create_class_with_framework
+from .metaprogramming import T, create_class_with_framework
 
 __all__ = [
     "MotorClient",
@@ -34,8 +33,6 @@
     "MotorClientEncryption",
 ]
 
-T = TypeVar("T")
-
 
 def create_motor_class(cls: T) -> T:
     return create_class_with_framework(cls, tornado_framework, "motor.motor_tornado")

mypy.ini

@@ -81,6 +81,37 @@ version = {attr = "motor._version.version"}
 [tool.setuptools.packages.find]
 include = ["motor"]
 
+[tool.mypy]
+python_version = "3.7"
+strict = true
+pretty = true
+show_error_context = true
+show_error_codes = true
+warn_redundant_casts = true
+warn_unreachable = true
+disable_error_code = ["type-arg"]
+enable_error_code = ["ignore-without-code", "redundant-expr", "truthy-bool"]
+
+[tool.pytest.ini_options]
+minversion = "7"
+testpaths = ["test"]
+xfail_strict = true
+log_cli_level = "INFO"
+addopts = ["-ra", "--strict-config", "--strict-markers",
+    "--maxfail=10", "--durations=5", "--junitxml=xunit-results/TEST-results.xml"]
+faulthandler_timeout = 1500
+filterwarnings = [
+    "error",
+    "ignore:Bare functions are deprecated, use async ones:DeprecationWarning",
+    "ignore:Application.make_handler:DeprecationWarning",
+    "ignore:unclosed <socket.socket:ResourceWarning",
+    "ignore:unclosed event loop:ResourceWarning",
+    "ignore: The fetch_next property is deprecated:DeprecationWarning",
+    "ignore:The next_object method is deprecated:DeprecationWarning",
+    "ignore:unclosed <ssl.SSLSocket:ResourceWarning",
+    "ignore:datetime.datetime.utcfromtimestamp:DeprecationWarning",
+    "ignore:datetime.datetime.utcnow:DeprecationWarning",
+]
 
 [tool.ruff]
 target-version = "py37"