Fix RBAC in multicluster tool

[lucian-tosa]

Summary

Our multicluster CLI tool didn't treat the "IsAlreadyExists" errors properly so some roles and clusterrolebindings were not updated when upgrading the operator.

Proof of Work

You can see that clusterrolebindings now are applied to the new service account, and the operator doesn't print any errors related to RBAC in the logs.

Here are the clusterrolebindings and the operator logs before.

Checklist

• Have you linked a jira ticket and/or is the ticket in the title?
• Have you checked whether your jira ticket required DOCSP changes?
• Have you checked for release_note changes?

Reminder (Please remove this when merging)

• Please try to Approve or Reject Changes the PR, keep PRs in review as short as possible
• Our Short Guide for PRs: Link
• Remember the following Communication Standards - use comment prefixes for clarity:
  • blocking: Must be addressed before approval.
  • follow-up: Can be addressed in a later PR or ticket.
  • q: Clarifying question.
  • nit: Non-blocking suggestions.
  • note: Side-note, non-actionable. Example: Praise
  • --> no prefix is considered a question

[MaciejKaras]

Nice finding!

How can we prevent this from happening again? Do we have tests for CLI that we can add this scenario?

[lucian-tosa]

Nice finding!

How can we prevent this from happening again? Do we have tests for CLI that we can add this scenario?

Our upgrade tests should check that all RBAC is configured properly, I can open a ticket for that