Tag latest readiness and versionhook when building on master #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nammn
approved these changes
Apr 29, 2025
mircea-cosbuc
added a commit
that referenced
this pull request
May 2, 2025
…#67) Reverts #57 The inventory task cannot work as pushing the multi-arch manifest required for this tagging job is only happening after the sonar instructions: https://github.com/mongodb/mongodb-kubernetes/blob/master/pipeline.py#L840-L853
3 tasks
lsierant
added a commit
that referenced
this pull request
Jul 15, 2025
…master (#205) # Summary This is another attempt at publishing latest tags of readiness probes and versionhooks from CI after master merges. The previous attempt (#57) was unsuccessful and was reverted. This problem affects multi-arch images as they're not using sonar and have multi-arch manifests pushed after sonar build in `pipeline.py`. Single-arch images have latest images published via [sonar inventory](https://github.com/mongodb/mongodb-kubernetes/blob/c242836b12a5108f69bb083b3bfb824e1977b4b8/inventories/database.yaml#L38) Current approach adds logic checking if we're not building from a patch (from PR or manually triggered evg pipeline) and in evg: ## Proof of Work ### Manual test It's difficult to trigger "master" build from PR, so a manual test was performed by changing the condition [here] (https://github.com/mongodb/mongodb-kubernetes/pull/205/files#diff-6b92e3e77956f8020482ca91889a24f3411c9a4854f2aaaac30ee504ef26ede4R1012) with changed tag to `latest-test` We can see `latest-test` pushed [here](https://parsley.mongodb.com/evergreen/mongodb_kubernetes_init_test_run_build_upgrade_hook_image_patch_c242836b12a5108f69bb083b3bfb824e1977b4b8_685507301df3100007f1d3ff_25_06_20_07_01_05/0/task?bookmarks=0%2C600&selectedLineRange=L595&shareLine=595) ### Build from PR When building from PR it's not pushing tag: [evg](https://parsley.mongodb.com/evergreen/mongodb_kubernetes_init_test_run_build_readiness_probe_image_patch_c242836b12a5108f69bb083b3bfb824e1977b4b8_68551d8d8be6120007ecfe96_25_06_20_08_36_31/0/task?bookmarks=0%2C551&selectedLineRange=L547&shareLine=547) The final test will be performed after merging. ## Checklist - [ ] Have you linked a jira ticket and/or is the ticket in the title? - [ ] Have you checked whether your jira ticket required DOCSP changes? - [ ] Have you checked for release_note changes? ## Reminder (Please remove this when merging) - Please try to Approve or Reject Changes the PR, keep PRs in review as short as possible - Our Short Guide for PRs: [Link](https://docs.google.com/document/d/1T93KUtdvONq43vfTfUt8l92uo4e4SEEvFbIEKOxGr44/edit?tab=t.0) - Remember the following Communication Standards - use comment prefixes for clarity: * **blocking**: Must be addressed before approval. * **follow-up**: Can be addressed in a later PR or ticket. * **q**: Clarifying question. * **nit**: Non-blocking suggestions. * **note**: Side-note, non-actionable. Example: Praise * --> no prefix is considered a question
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Readiness probe and version hook images are not tagged with "latest" when built on master. It fills the gap after merging repositories. All other images are built with latest allowing to use "latest" tag for most auxiliary images when testing locally.
Proof of Work
If green, then the change is safe. Then we will verify it on master as it's difficult to recreate master merge conditions in patch build.
Checklist