Skip to content

Add OPERATOR_NAME env var in .generated files for operator #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025

Conversation

viveksinghggits
Copy link
Contributor

Summary

As part of one of the recent changes #222 we added a new env var OPERATOR_NAME. After switching the context this env var was correctly populated in the generated files context.env and context.export.env but it was not being populated in the other generated files (context.operator.env and context.operator.export.env). This PR fixes that.

Proof of Work

Switch context either using make switch context=<context> or make switcht and make sure the operator name is populated in the generated files (context.env, context.export.env, context.operator.env and context.operator.export.env).

Checklist

  • Have you linked a jira ticket and/or is the ticket in the title?: NA
  • Have you checked whether your jira ticket required DOCSP changes?
  • Have you checked for release_note changes?

Reminder (Please remove this when merging)

  • Please try to Approve or Reject Changes the PR, keep PRs in review as short as possible
  • Our Short Guide for PRs: Link
  • Remember the following Communication Standards - use comment prefixes for clarity:
    • blocking: Must be addressed before approval.
    • follow-up: Can be addressed in a later PR or ticket.
    • q: Clarifying question.
    • nit: Non-blocking suggestions.
    • note: Side-note, non-actionable. Example: Praise
    • --> no prefix is considered a question

As part of one of the recent changes #222
we added a new env var OPERATOR_NAME. After switching the context this env var was correctly
populated in the generated files `context.env` and `context.export.env` but it was not being
populated in the other generated files (`context.operator.env` and `context.operator.export.env`).
This commit fixes that.
Copy link
Contributor

@m1kola m1kola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling this!

@viveksinghggits viveksinghggits merged commit 1bccada into master Jul 15, 2025
35 checks passed
@viveksinghggits viveksinghggits deleted the fix-operator-name-in-generated branch July 15, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants