minor: bump clippy to 1.78.0 (#1096)

Author: isabelatkinson

.evergreen/check-clippy.sh

@@ -5,12 +5,12 @@ set -o errexit
 source ./.evergreen/env.sh
 
 # Pin clippy to the latest version. This should be updated when new versions of Rust are released.
-CLIPPY_VERSION=1.75.0
+CLIPPY_VERSION=1.78.0
 
 rustup install $CLIPPY_VERSION
 
 # Check with default features.
 cargo +$CLIPPY_VERSION clippy --all-targets -p mongodb -- -D warnings
 
 # Check with all features.
-cargo +$CLIPPY_VERSION clippy --all-targets --all-features -p mongodb -- -D warnings
+cargo +$CLIPPY_VERSION clippy --all-targets --all-features -p mongodb -- -D warnings

src/client/auth/oidc.rs

@@ -279,7 +279,7 @@ impl Cache {
             self.idp_server_info = idp_server_info;
         }
         self.access_token = Some(response.access_token.clone());
-        self.refresh_token = response.refresh_token.clone();
+        self.refresh_token.clone_from(&response.refresh_token);
         self.last_call_time = Instant::now();
         self.token_gen_id += 1;
     }

src/client/options/parse.rs

@@ -21,7 +21,7 @@ impl Action for ParseConnectionString {
         let mut options = ClientOptions::from_connection_string(conn_str);
         #[cfg(feature = "dns-resolver")]
         {
-            options.resolver_config = self.resolver_config.clone();
+            options.resolver_config.clone_from(&self.resolver_config);
         }
 
         let resolved = host_info.resolve(self.resolver_config).await?;

src/lib.rs

@@ -4,7 +4,7 @@
 #![warn(clippy::cast_possible_truncation)]
 #![warn(clippy::cast_possible_wrap)]
 #![cfg_attr(
-    feature = "cargo-clippy",
+    feature = "clippy",
     allow(
         clippy::unreadable_literal,
         clippy::cognitive_complexity,

src/sdam/description/topology.rs

@@ -175,7 +175,7 @@ impl TopologyDescription {
         }
 
         self.single_seed = self.servers.len() == 1;
-        self.set_name = options.repl_set_name.clone();
+        self.set_name.clone_from(&options.repl_set_name);
         self.local_threshold = options.local_threshold;
         self.heartbeat_freq = options.heartbeat_freq;
         self.srv_max_hosts = options.srv_max_hosts;

src/sdam/srv_polling/test.rs

@@ -43,7 +43,7 @@ async fn run_test_extra(
     new_hosts: Result<Vec<ServerAddress>>,
 ) -> HashSet<ServerAddress> {
     let mut options = ClientOptions::new_srv();
-    options.hosts = DEFAULT_HOSTS.clone();
+    options.hosts.clone_from(&DEFAULT_HOSTS);
     options.test_options_mut().disable_monitoring_threads = true;
     options.srv_max_hosts = max_hosts;
     let mut topology = Topology::new(options.clone()).unwrap();
@@ -132,7 +132,7 @@ async fn load_balanced_no_srv_polling() {
     let hosts = vec![localhost_test_build_10gen(27017)];
     let mut options = ClientOptions::new_srv();
     let rescan_interval = options.original_srv_info.as_ref().cloned().unwrap().min_ttl;
-    options.hosts = hosts.clone();
+    options.hosts.clone_from(&hosts);
     options.load_balanced = Some(true);
     options.test_options_mut().mock_lookup_hosts = Some(make_lookup_hosts(vec![
         localhost_test_build_10gen(27017),

src/test.rs

@@ -114,7 +114,7 @@ pub(crate) static DEFAULT_GLOBAL_TRACING_HANDLER: Lazy<TracingHandler> = Lazy::n
 
 pub(crate) fn update_options_for_testing(options: &mut ClientOptions) {
     if options.server_api.is_none() {
-        options.server_api = SERVER_API.clone();
+        options.server_api.clone_from(&SERVER_API);
     }
 
     #[cfg(any(

src/test/spec/initial_dns_seedlist_discovery.rs

@@ -135,7 +135,9 @@ async fn run_test(mut test_file: TestFile) {
     } else {
         let mut options_with_tls = options.clone();
         if requires_tls {
-            options_with_tls.tls = get_client_options().await.tls.clone();
+            options_with_tls
+                .tls
+                .clone_from(&get_client_options().await.tls);
         }
 
         let client = Client::with_options(options_with_tls).unwrap();

src/test/spec/retryable_reads.rs

@@ -138,9 +138,8 @@ async fn retry_read_pool_cleared() {
         .expect("pool clear should occur");
 
     let next_cmap_events = subscriber
-        .collect_events(Duration::from_millis(1000), |event| match event {
-            Event::Cmap(_) => true,
-            _ => false,
+        .collect_events(Duration::from_millis(1000), |event| {
+            matches!(event, Event::Cmap(_))
         })
         .await;
 

src/test/spec/retryable_writes.rs

@@ -49,7 +49,7 @@ async fn run_legacy() {
                 continue;
             }
             let mut options = test_case.client_options.unwrap_or_default();
-            options.hosts = get_client_options().await.hosts.clone();
+            options.hosts.clone_from(&get_client_options().await.hosts);
             if options.heartbeat_freq.is_none() {
                 options.heartbeat_freq = Some(MIN_HEARTBEAT_FREQUENCY);
             }
@@ -455,9 +455,8 @@ async fn retry_write_pool_cleared() {
         .expect("pool clear should occur");
 
     let next_cmap_events = subscriber
-        .collect_events(Duration::from_millis(1000), |event| match event {
-            Event::Cmap(_) => true,
-            _ => false,
+        .collect_events(Duration::from_millis(1000), |event| {
+            matches!(event, Event::Cmap(_))
         })
         .await;
 

src/test/spec/trace.rs

@@ -49,27 +49,27 @@ fn tracing_truncation() {
     assert_eq!(s, String::from("..."));
 
     // we should "round up" to the end of the first emoji
-    s = two_emoji.clone();
+    s.clone_from(&two_emoji);
     truncate_on_char_boundary(&mut s, 1);
     assert_eq!(s, String::from("🤔..."));
 
     // 4 is a boundary, so we should truncate there
-    s = two_emoji.clone();
+    s.clone_from(&two_emoji);
     truncate_on_char_boundary(&mut s, 4);
     assert_eq!(s, String::from("🤔..."));
 
     // we should round up to the full string
-    s = two_emoji.clone();
+    s.clone_from(&two_emoji);
     truncate_on_char_boundary(&mut s, 5);
     assert_eq!(s, two_emoji);
 
     // end of string is a boundary, so we should truncate there
-    s = two_emoji.clone();
+    s.clone_from(&two_emoji);
     truncate_on_char_boundary(&mut s, 8);
     assert_eq!(s, two_emoji);
 
     // we should get the full string back if the new length is longer than the original
-    s = two_emoji.clone();
+    s.clone_from(&two_emoji);
     truncate_on_char_boundary(&mut s, 10);
     assert_eq!(s, two_emoji);
 }

src/test/spec/unified_runner/operation.rs

@@ -124,6 +124,7 @@ pub(crate) trait TestOperation: Debug + Send + Sync {
 
     /// If this operation specifies entities to create, returns those entities. Otherwise,
     /// returns None.
+    #[cfg(feature = "tracing-unstable")]
     fn test_file_entities(&self) -> Option<&Vec<TestFileEntity>> {
         None
     }
@@ -2307,7 +2308,7 @@ impl TestOperation for RenameCollection {
             let target = test_runner.get_collection(id).await;
             let ns = target.namespace();
             let mut to_ns = ns.clone();
-            to_ns.coll = self.to.clone();
+            to_ns.coll.clone_from(&self.to);
             let cmd = doc! {
                 "renameCollection": crate::bson::to_bson(&ns)?,
                 "to": crate::bson::to_bson(&to_ns)?,
@@ -2741,6 +2742,7 @@ impl TestOperation for CreateEntities {
             .boxed()
     }
 
+    #[cfg(feature = "tracing-unstable")]
     fn test_file_entities(&self) -> Option<&Vec<TestFileEntity>> {
         Some(&self.entities)
     }

src/test/spec/unified_runner/test_file.rs

@@ -500,7 +500,7 @@ impl ExpectError {
         let description = description.as_ref();
 
         if let Some(is_client_error) = self.is_client_error {
-            if is_client_error != !error.is_server_error() {
+            if is_client_error == error.is_server_error() {
                 return Err(format!(
                     "{}: expected client error but got {:?}",
                     description, error