PYTHON-3075 [Backport-3.13] bulk_write does not apply CodecOptions to upserted_ids result #842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
evergreen patch |
ShaneHarvey
reviewed
Feb 2, 2022
test/test_bulk.py
Outdated
| options = CodecOptions(uuid_representation=UuidRepresentation.STANDARD) | ||
| coll = self.coll.with_options(codec_options=options) | ||
| ids = [ | ||
| {'f': Binary(bytes(i)), 'f2': uuid.uuid4()} |
There was a problem hiding this comment.
This test runs into a bytes/binary issue on python 2. Is there any point of using 'f': Binary(bytes(i))? What if we just did 'f': i?
ShaneHarvey
reviewed
Feb 2, 2022
| @@ -27,7 +27,7 @@ | |||
| HAS_SNI as _HAVE_SNI, | |||
| IPADDR_SAFE as _IPADDR_SAFE) | |||
|
|
|||
| from bson import DEFAULT_CODEC_OPTIONS | |||
| from bson import DEFAULT_CODEC_OPTIONS, codec_options | |||
There was a problem hiding this comment.
Importing codec_options is not needed. Is your editor adding this automatically by accident?
There was a problem hiding this comment.
Yeah, I just disabled it
|
Encryption job is passing. |
ShaneHarvey
approved these changes
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.