PYTHON-5289 Validate ignored bits are 0 on write for bson.BinaryVector #2397
+29
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s will sync up with specifications when pull/1812 is merged.
|
Failing tests are unrelated. |
NoahStapp
reviewed
Jun 27, 2025
| @@ -522,6 +530,12 @@ def as_vector(self) -> BinaryVector: | |||
| dtype_format = "B" | |||
| format_string = f"<{n_values}{dtype_format}" | |||
| unpacked_uint8s = list(struct.unpack_from(format_string, self, position)) | |||
| if padding and n_values and unpacked_uint8s[-1] & (1 << padding) - 1 != 0: | |||
| warnings.warn( | |||
| "Vector has a padding P, but bits in the final byte lower than P are non-zero. In the next major version, they must be zero.", | |||
There was a problem hiding this comment.
So in the next major version, this warning will become an error to match the behavior in from_vector?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the implementation of the spec changes applied in specifications/pull/1812.