PHPLIB-493: Unified test runner POC #783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
reviewed
Sep 23, 2020
jmikola
commented
Sep 29, 2020
alcaeus
reviewed
Sep 29, 2020
jmikola
changed the title
|
Includes patch from #790 for CreateIndexes. Also syncs spec tests with mongodb/specifications#846, all of which are currently passing locally on replica set and sharded clusters. We'll see what Travis and Evergreen say. |
alcaeus
reviewed
Oct 8, 2020
| return (int) ((string) $bson); | ||
| } | ||
|
|
||
| /* TODO: Convert Int64 objects to integers on 32-bit platforms if they |
There was a problem hiding this comment.
I suppose this will only be relevant once we port over more tests to the new format?
There was a problem hiding this comment.
It may actually never come up unless a test actually asserts that a cursor ID is zero and a 32-bit PHP platform tries to compare 0 with Int64(0). I think you could probably punt on this until it actually becomes an issue.
alcaeus
approved these changes
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPLIB-493