PHPLIB-1662 Update GHA test jobs to newer ubuntu version #1669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
requested review from
jmikola and
alcaeus
and removed request for
jmikola
alcaeus
reviewed
Apr 11, 2025
There was a problem hiding this comment.
We could run legacy versions of the server in docker
I don't think that's necessary, as we test with all versions in Evergreen. The GHA pipeline is mainly here to give us and external contributors quick feedback, and the latest stable release is probably a better reference point anyways.
alcaeus
approved these changes
Apr 11, 2025
This was referenced Apr 11, 2025
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PHPLIB-1662
We could run legacy versions of the server in docker, as done in the laravel package.