Don't build with PHPC 1.x on legacy PHP versions #1456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
approved these changes
Sep 25, 2024
Merged
alcaeus
added a commit
that referenced
this pull request
Sep 25, 2024
* v1.20: Don't build with PHPC 1.x on legacy PHP versions (#1456)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next minor version of PHPC drops support for PHP 7.4 and 8.0, which means that those builds currently fail on evergreen. This PR ensures we only build with PHPC 1.x on PHP 8.1+. This PR can be ignored when merging up to v1.x (i.e., use the "ignoring changes" instructions in the merge-up pull request)