PHPLIB-1482: Skip range V1 tests on ext-mongodb 1.20+ #1351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
changed the title
ext-mongodb 1.20 uses libmongoc 1.28, which enables range V2 from libmongocrypt 1.10+ and drops support for range V1.
jmikola
force-pushed
the
1.19-phplib-1393
branch
from
8cb2bd5 to
b12a5f1
Compare
|
evergreen keep-definitions |
|
I see that the fle2v2-Compact.yml test is still failing. This seems related to the libmongoc 1.28 bump in ext-mongodb, as it dates back to this CI build when all of the range V1 tests started failing. However, that test file wasn't changed in mongodb/specifications@9bfa512, so it's not clear to me how it's related. DRIVERS-2629 alludes to it being specially processed by libmongocrypt, so this may be an upstream issue. |
alcaeus
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPLIB-1482
ext-mongodb 1.20 uses libmongoc 1.28, which enables range V2 from libmongocrypt 1.10+ and drops support for range V1.
This should address test failures for
build-php-%phpVersion%-next-minortasks in Evergreen.If this is merged to v1.19 and then merged up to master, there will be a conflict with #1350. Since #1350 is blocked on adding MongoDB 8.0 to CI, it may be prudent to rebase that PR after this is merged and then remove these changes there.