PHPLIB-1174: Rely on Binary constructor default type #1121
Conversation
| @@ -283,7 +283,7 @@ private function insertChunkFromBuffer(): void | |||
| $chunk = [ | |||
| 'files_id' => $this->file['_id'], | |||
| 'n' => $this->chunkOffset, | |||
| 'data' => new Binary($data, Binary::TYPE_GENERIC), | |||
| 'data' => new Binary($data), | |||
There was a problem hiding this comment.
The psalm error may be due to outdated stubs.
Strangely, it only alerts on this line, whereas it should be the same everywhere you've modified the call to new Binary.
I propose that you update the baseline until JetBrains/phpstorm-stubs#1553.
There was a problem hiding this comment.
Aye, forgot to run CS tools locally. I'll get this fixed up.
There was a problem hiding this comment.
Just noticed that the Binary stub was never updated for PHPC-2101. I opened PHPORM-40 to track that, as there might have been other things missed in v1.15.
There was a problem hiding this comment.
@GromNaN: What does PhpStorm have to do with Psalm?
The Psalm stub for ext-mongodb only defines a few things with generics. I don't see anything in Psalm's composer.json that pulls in PhpStorm stubs.
I was under the impression that Psalm inferred extension APIs via Reflection, which should be correct.
There was a problem hiding this comment.
Exact. Sorry for the confusion.
Suppress the TooFewArguments error since Psalm is not aware of the Binary constructor's default type.
|
Docs build failure is unrelated. I'm tracking that in PHPLIB-1175. |
https://jira.mongodb.org/browse/PHPLIB-1174