Skip to content

Add tests on client bulk write replaceOne, updateMany and deleteMany #1820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented May 7, 2025

  • replaceOne tests are copied from updateOne
  • deleteMany tests are copied from deleteOne
  • renamed files testing updateMany

@GromNaN GromNaN requested a review from alcaeus May 7, 2025 12:07
@GromNaN GromNaN requested a review from a team as a code owner May 7, 2025 12:07
@GromNaN GromNaN merged commit ef9a2fc into mongodb:feature/client-bulk-write May 7, 2025
60 checks passed
@GromNaN GromNaN deleted the bulk-write-tests branch May 7, 2025 12:28
@GromNaN GromNaN mentioned this pull request May 7, 2025
3 tasks
alcaeus pushed a commit that referenced this pull request May 9, 2025
* PHPC-2478: Implement API for bulkWrite command (#1790)

* PHPC-2495, PHPC-2490, PHPC-2491, PHPC-2492: BulkWriteCommand ctor and ops

* PHPC-2494: BulkWriteCommandResult and BulkWriteCommandException

It was possible to reuse WriteConcernError and WriteError with slight changes to their init functions.

* Include missing header in WriteResult.h

This was not necessary for compilation, but it makes the header internally consistent.

* PHPC-2493: Manager and Server::executeBulkWriteCommand()

* PHPC-2494: Handle null error fields in BulkWriteCommandResult

Always return arrays for writeErrors and writeConcernErrors

* PHPC-2494: Return writeErrors as an associative array

* PHPC-2493: Revise error handling for mongoc_bulkwrite_execute

* Consistent WriteError and WriteConcernError parsing for bulk write results

* BulkWriteCommand tests

* clang-format

* Remove BulkWriteCommandResult::getServer()

Per CDRIVER-5843, libmongoc does not consistently populate this field. It also isn't required by the spec, so omit it for now.

* Check for _id extraction before appending insert

* Regenerate BulkWriteCommandException arginfo

* PHPC-2493: Relocate writeConcern option to executeBulkWriteCommand()

* Parse sort option for replaceOne and updateOne

* BulkWriteCommand::replaceOne() need not accept root-level arrays

* Preserve empty documents for verbose results and error reply

Result maps should only be null if verboseResults=false. Additionally, the error reply document can default to an empty document on error (as it is in libmongoc).

* PHPC-2494: Relocate error fields to BulkWriteCommandException

Revise the stubs to reflect that executeBulkWriteCommand() always returns a BulkWriteCommandResult. If the result is unacknowledged, that is reported via isAcknowledged() and other methods can throw, which is consistent with WriteResult for the legacy bulk write API.

If the result is empty on error (i.e. no writes were successful), BulkWriteCommandException::$partialResult is left unset.

* Throw BulkWriteCommandException directly for server errors

This also ensures that BulkWriteCommandException uses the original server-side error code and message (if available) for top-level errors.

* Check for empty error_reply instead of NULL

mongoc_bulkwriteexception_errorreply() always returns an initialized document, but it may be empty. This ensures that an InvalidArgumentException is not unnecessarily proxied behind a BulkWriteCommandException.

* PHPC-2571 Import BulkWrite tests for Client BulkWriteCommand (#1819)

* Add tests on client bulk write replaceOne, updateMany and deleteMany (#1820)

---------

Co-authored-by: Jeremy Mikola <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants