Skip to content

Use correct name for PDB file for pie installs. #1745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Use correct name for PDB file for pie installs. #1745

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/build-windows-package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,17 +117,18 @@ jobs:
echo FILENAME="php_mongodb-${{ inputs.version }}-${{ inputs.php }}-${{ inputs.ts }}-${{ needs.build.outputs.vs }}-${{ inputs.arch == 'x64' && 'x64_86' || inputs.arch }}" >> "$GITHUB_ENV"

# In this step, we:
# - update the extension DLL file name to match the expectation of pie
# - update the extension DLL and PDB file names to match the expectation of pie
# - copy the signature file from the release asset directory to avoid directory issues in the archive
# - rename the signature file to match the extension DLL file
- name: "Copy signature file and use correct file names"
run: |
mv php_mongodb.dll ${{ env.FILENAME }}.dll
mv php_mongodb.pdb ${{ env.FILENAME }}.pdb
cp ${RELEASE_ASSETS}/php_mongodb.dll.sig ${{ env.FILENAME }}.dll.sig

- name: "Create and upload release asset"
if: ${{ inputs.upload_release_asset }}
run: |
ARCHIVE=${{ env.FILENAME }}.zip
zip ${ARCHIVE} ${{ env.FILENAME }}.dll ${{ env.FILENAME }}.dll.sig php_mongodb.pdb CREDITS CONTRIBUTING.md LICENSE README.md THIRD_PARTY_NOTICES
zip ${ARCHIVE} ${{ env.FILENAME }}.dll ${{ env.FILENAME }}.dll.sig ${{ env.FILENAME }}.pdb CREDITS CONTRIBUTING.md LICENSE README.md THIRD_PARTY_NOTICES
gh release upload ${{ inputs.version }} ${ARCHIVE}